Create a Default trait for an empty format string
#8564
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
By using a separate trait this is overridable on a per-type basis and makes room for the possibility of even more arguments passed in for the future.
bors
added a commit
that referenced
this pull request
Aug 19, 2013
See discussion in #8489, but this selects option 3 by adding a `Default` trait to be implemented by various basic types. Once this makes it into a snapshot I think it's about time to start overhauling all current use-cases of `fmt!` to move towards `ifmt!`. The goal is to replace `%X` with `{}` in 90% of situations, and this commit should enable that.
flip1995
pushed a commit
to flip1995/rust
that referenced
this pull request
Jun 4, 2022
…endoo Don't lint `useless_transmute` on types with erased regions fixes rust-lang#6356 fixes rust-lang#3340 fixes rust-lang#2906 This should get a proper fix at some point, but this at least gets the lint running on some types. cc rust-lang#5343 changelog: Don't lint `useless_transmute` on types with erased regions
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See discussion in #8489, but this selects option 3 by adding a
Defaulttrait to be implemented by various basic types.Once this makes it into a snapshot I think it's about time to start overhauling all current use-cases of
fmt!to move towardsifmt!. The goal is to replace%Xwith{}in 90% of situations, and this commit should enable that.