SGX mutex is movable #85029
Merged
SGX mutex is movable #85029
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nagisa
reviewed
May 7, 2021
| @@ -8,7 +8,7 @@ pub struct Mutex { | |||
| inner: SpinMutex<WaitVariable<bool>>, | |||
| } | |||
|
|
|||
| pub type MovableMutex = Box<Mutex>; | |||
| pub type MovableMutex = Mutex; | |||
There was a problem hiding this comment.
Is this truly a pub type or just pub(crate) one? If the former, then this is a breaking change.
There was a problem hiding this comment.
Pretty much everything in sys is just pub(crate). The only thing we expose is std::sync::Mutex; all the mutex stuff in sys and sys_common are just implementation details.
|
@bors r+ |
|
📌 Commit 30b82e0 has been approved by |
Dylan-DPC-zz
pushed a commit
to Dylan-DPC-zz/rust
that referenced
this pull request
May 7, 2021
…ou-se SGX mutex is movable r? `@m-ou-se`
This was referenced May 7, 2021
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
May 7, 2021
Rollup of 9 pull requests Successful merges: - rust-lang#84254 (illumos should put libc last in library search order) - rust-lang#84442 (Unify rustc and rustdoc parsing of `cfg()`) - rust-lang#84655 (Cleanup of `wasm`) - rust-lang#84866 (linker: Avoid library duplication with `/WHOLEARCHIVE`) - rust-lang#84930 (rename LLVM target for RustyHermit) - rust-lang#84991 (rustc: Support Rust-specific features in -Ctarget-feature) - rust-lang#85029 (SGX mutex is movable) - rust-lang#85030 (Rearrange SGX split module files) - rust-lang#85033 (some further small cleanups) Failed merges: r? `@ghost` `@rustbot` modify labels: rollup
GuillaumeGomez
added a commit
to GuillaumeGomez/rust
that referenced
this pull request
Jul 27, 2021
…=dtolnay SGX mutex is *not* moveable Reverts the erroneous change in rust-lang#85029.
JohnTitor
added a commit
to JohnTitor/rust
that referenced
this pull request
Jul 28, 2021
…=dtolnay SGX mutex is *not* moveable Reverts the erroneous change in rust-lang#85029.
JohnTitor
added a commit
to JohnTitor/rust
that referenced
this pull request
Jul 28, 2021
…=dtolnay SGX mutex is *not* moveable Reverts the erroneous change in rust-lang#85029.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
r? @m-ou-se