Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rollup of 4 pull requests #84370

Closed
wants to merge 14 commits into from
Closed

Rollup of 4 pull requests #84370

wants to merge 14 commits into from

Conversation

Dylan-DPC-zz
Copy link

Successful merges:

Failed merges:

r? @ghost
@rustbot modify labels: rollup

Create a similar rollup

sunjay and others added 14 commits March 24, 2021 20:25
@sunjay
Tests for field is never read diagnostic
30fc601
@sunjay
Added suggestion and note for when a field is never used
321aace
@sunjay
Updating test stderr files
7faaf39
@sunjay
Trying out a new message that works a little better for values *and* …
789186d 
…items
@sunjay
New shorter diagnostic note that is different for items versus fields
2acd8eb
@sunjay
Putting help message only under the identifier that needs to be prefixed
3e34eb8
@JohnTitor
Add a suggestion when using a type alias instead of trait alias
539242a
@JohnTitor
Mention trait alias on the E0404 note
eea27b8
@lnicola
⬆️ rust-analyzer
e85f19b
@vext01
Improve the docstrings of the Lto struct.
8cc918a
@Dylan-DPC
Rollup merge of rust-lang#83004 - sunjay:field-never-read-issue-81658…
c8e5d46 
…, r=pnkfelix

Improve diagnostic for when field is never read

Related to (but does not close) rust-lang#81658

This completes the first step of ``@pnkfelix's`` [mentoring instructions](rust-lang#81658 (comment)) but does not actually improve the diagnostics (yet!). The two tests are heavily reduced versions of code from the original bug report.

I've confirmed that the reduced `field-used-in-ffi` test [fails on nightly](https://play.rust-lang.org/?version=nightly&mode=debug&edition=2018&gist=f0862c89ddca028c55c20a5ed05e679a) but [passes on stable](https://play.rust-lang.org/?version=stable&mode=debug&edition=2018&gist=f0862c89ddca028c55c20a5ed05e679a). This confirms that the regression is reproduced correctly. The `drop-only-field` test is a case that ``@pnkfelix`` mentioned in his mentoring instructions. It is not a regression, but will come in handy when we make the diagnostic smarter by looking at whether the field type implements `Drop`.

Per the [rustc-dev-guide](https://rustc-dev-guide.rust-lang.org/tests/adding.html), each test includes a comment summarizing what it is about.
@Dylan-DPC
Rollup merge of rust-lang#83729 - JohnTitor:issue-43913, r=estebank
66cf14a 
Add a suggestion when using a type alias instead of trait alias

Fixes rust-lang#43913

r? ``@estebank``
@Dylan-DPC
Rollup merge of rust-lang#84359 - lnicola:rust-analyzer-2021-04-20, r…
09135f6 
…=jonas-schievink

⬆️ rust-analyzer
@Dylan-DPC
Rollup merge of rust-lang#84365 - vext01:improve-lto-docstrings, r=pe…
530b02f 
…trochenkov

Improve the docstrings of the `Lto` struct.

This change is the result of [this zulip discussion](https://rust-lang.zulipchat.com/#narrow/stream/182449-t-compiler.2Fhelp/topic/Making.20sense.20of.20LTO.20modes.20in.20rustc).

Hopefully it makes things a little clearer. What do you think?
@rustbot rustbot added the rollup A PR which is a rollup label Apr 20, 2021
@Dylan-DPC-zz
Copy link
Author

@bors r+ rollup=never p=5

@bors
Copy link
Contributor

bors commented Apr 20, 2021

📌 Commit 530b02f has been approved by Dylan-DPC

@bors bors added the S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. label Apr 20, 2021
@bors
Copy link
Contributor

bors commented Apr 20, 2021

⌛ Testing commit 530b02f with merge 3236ddb351992ead5eb98580023cea85fcfddc58...

@rust-log-analyzer
Copy link
Collaborator

The job x86_64-gnu-aux failed! Check out the build log: (web) (plain)

Click to see the possible cause of the failure (guessed by this bot) 
test test::test_workspaces_cwd ... ok

failures:

---- fix::fix_deny_warnings_but_not_others stdout ----
running `/checkout/obj/build/x86_64-unknown-linux-gnu/stage2-tools/x86_64-unknown-linux-gnu/release/cargo fix --allow-no-vcs`
thread 'fix::fix_deny_warnings_but_not_others' panicked at 'assertion failed: p.read_file(\"src/lib.rs\").contains(\"fn bar() {}\")', src/tools/cargo/tests/testsuite/fix.rs:572:5


failures:
    fix::fix_deny_warnings_but_not_others
---


failed to run: /checkout/obj/build/bootstrap/debug/bootstrap test --stage 2 src/tools/cargo src/tools/cargotest
Build completed unsuccessfully in 0:24:27
make: *** [check-aux] Error 1
Makefile:44: recipe for target 'check-aux' failed

@bors
Copy link
Contributor

bors commented Apr 20, 2021

💔 Test failed - checks-actions

@bors bors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Apr 20, 2021
@m-ou-se m-ou-se mentioned this pull request Apr 24, 2021
Closed
@m-ou-se m-ou-se closed this Apr 24, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
rollup A PR which is a rollup S-waiting-on-review Status: Awaiting review from the assignee but also interested parties.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
10 participants
@Dylan-DPC-zz @bors @rust-log-analyzer @m-ou-se @rustbot @sunjay @JohnTitor @lnicola @vext01 @Dylan-DPC