Match against attribute name when validating attributes

[tmiasko]

Extract attribute name once and match it against symbols that are being
validated, instead of using Session::check_name for each symbol
individually.

Assume that all validated attributes are used, instead of marking them
as such, since the attribute check should be exhaustive.

[rust-highfive]

r? @davidtwco

(rust-highfive has picked a reviewer for you, use r? to override)

[tmiasko]

@bors try @rust-timer queue

[rust-timer]

Awaiting bors try build completion.

@rustbot label: +S-waiting-on-perf

[bors]

⌛ Trying commit 985ae0b with merge 036cdad2e25b454b350ae4ca23bc0dc4f57dc093...

[bors]

☀️ Try build successful - checks-actions
Build commit: 036cdad2e25b454b350ae4ca23bc0dc4f57dc093 (036cdad2e25b454b350ae4ca23bc0dc4f57dc093)

[rust-timer]

Queued 036cdad2e25b454b350ae4ca23bc0dc4f57dc093 with parent 58f32da, future comparison URL.

[cjgillot]

In order to make this even more exhaustive, you could even iterate on all the attributes directly instead of visiting.

[rust-timer]

Finished benchmarking try commit (036cdad2e25b454b350ae4ca23bc0dc4f57dc093): comparison url.

Benchmarking this pull request likely means that it is perf-sensitive, so we're automatically marking it as not fit for rolling up. Please note that if the perf results are neutral, you should likely undo the rollup=never given below by specifying rollup- to bors.

Importantly, though, if the results of this run are non-neutral do not roll this PR up -- it will mask other regressions or improvements in the roll up.

@bors rollup=never
@rustbot label: +S-waiting-on-review -S-waiting-on-perf

[davidtwco]

@bors r+

[bors]

📌 Commit 985ae0b has been approved by davidtwco

[bors]

⌛ Testing commit 985ae0b with merge 1519ff3c75ad405fe39169328e382b4280ca8ca0...

[rust-log-analyzer]

The job dist-aarch64-apple failed! Check out the build log: (web) (plain)

Click to see the possible cause of the failure (guessed by this bot)

      Memory: 14 GB
      Boot ROM Version: VMW71.00V.13989454.B64.1906190538
      Apple ROM Info: [MS_VM_CERT/SHA1/27d66596a61c48dd3dc7216fd715126e33f59ae7]Welcome to the Virtual Machine
      SMC Version (system): 2.8f0
      Serial Number (system): VM0dTlwGiAKN

hw.ncpu: 3
hw.byteorder: 1234
hw.memsize: 15032385536
---
[  8%] Building CXX object Common/CMakeFiles/lldCommon.dir/Args.cpp.o
error: Connection to server timed outerror: error: Connection to server timed out
Connection to server timed out

make[2]: *** [lib/Core/CMakeFiles/lldCore.dir/Error.cpp.o] Error 2
make[2]: *** Waiting for unfinished jobs....
make[2]: *** [lib/Core/CMakeFiles/lldCore.dir/DefinedAtom.cpp.o] Error 2
make[2]: *** [Common/CMakeFiles/lldCommon.dir/Args.cpp.o] Error 2
make[1]: *** [Common/CMakeFiles/lldCommon.dir/all] Error 2
make[1]: *** Waiting for unfinished jobs....
make[1]: *** [lib/Core/CMakeFiles/lldCore.dir/all] Error 2
make: *** [all] Error 2
command did not execute successfully, got: exit code: 2


build script failed, must exit now', /Users/runner/.cargo/registry/src/github.com-1ecc6299db9ec823/cmake-0.1.44/src/lib.rs:885:5
 finished in 21.022 seconds
failed to run: /Users/runner/work/rust/rust/build/bootstrap/debug/bootstrap dist --stage 2
Build completed unsuccessfully in 1:44:08

[bors]

💔 Test failed - checks-actions

[Aaron1011]

@bors retry

[bors]

⌛ Testing commit 985ae0b with merge 1a6c98e...

[bors]

☀️ Test successful - checks-actions
Approved by: davidtwco
Pushing 1a6c98e to master...