Code

Update Clippy#80239

Code

Merged

bors merged 114 commits intorust-lang:masterrust-lang/rust:masterfrom flip1995:clippyupflip1995/rust:clippyupCopy head branch name to clipboardDec 21, 2020

+3,201-1,049

Commits

Commits on Nov 22, 2020

• Use article_and_description for missing docs

  camsteffen

  committed
  a8c4744

  Copy full SHA for a8c4744

Commits on Nov 27, 2020

• Add --no-deps command-line argument

  ebroto

  committed
  0387981

  Copy full SHA for 0387981

• Update README.md

  ebroto

  committed
  192ccfb

  Copy full SHA for 192ccfb

• Apply suggestion regarding clippy_enabled bool

  ebroto

  committed
  7eda421

  Copy full SHA for 7eda421

• Make --fix imply --no-deps

  ebroto

  committed
  a83eb7c

  Copy full SHA for a83eb7c

• Reword bitrotten comment

  ebroto

  committed
  952b731

  Copy full SHA for 952b731

Commits on Nov 29, 2020

• Add redundant else lint

  camsteffen

  committed
  f059feb

  Copy full SHA for f059feb

• Eat redundant else dogfood

  camsteffen

  committed
  70f6a2c

  Copy full SHA for 70f6a2c

Commits on Dec 5, 2020

• fix clippy test

  vn-ki

  committed
  4e14c05

  Copy full SHA for 4e14c05

Commits on Dec 6, 2020

• Implement lowering of if-let guards to MIR

  LeSeulArtichaut

  committed
  402f55f

  Copy full SHA for 402f55f

• Handle Guard::IfLet in clippy

  LeSeulArtichaut

  committed
  93c6135

  Copy full SHA for 93c6135

• Merge commit 'c1664c50b27a51f7a78c93ba65558e7c33eabee6' into clippyup

  flip1995

  committed
  8eca423

  Copy full SHA for 8eca423

• Retain assembly operands span when lowering AST to HIR

  tmiasko

  committed
  0e527ba

  Copy full SHA for 0e527ba

Commits on Dec 7, 2020

• Fix FP in unnecessary_lazy_evaluations

  giraffate

  committed
  e90b977

  Copy full SHA for e90b977

• cargo dev fmt

  giraffate

  committed
  ba12494

  Copy full SHA for ba12494

• Auto merge of rust-lang#6370 - giraffate:fix_fp_in_unnecessary_lazy_evaluations, r=llogiq,flip1995

  Show description for aaed9d9
  bors

  committed
  aaed9d9

  Copy full SHA for aaed9d9

• Add lint print_stderr

  Show description for b81141c
  

  justjosias

  authored and

  ebroto

  committed
  b81141c

  Copy full SHA for b81141c

• Add negative tests

  

  justjosias

  authored and

  ebroto

  committed
  51cee15

  Copy full SHA for 51cee15

• Fix print_stderr.stderr test

  

  justjosias

  authored and

  ebroto

  committed
  b04bfbd

  Copy full SHA for b04bfbd

• Add eprint! to print_with_newline lint

  

  justjosias

  authored and

  ebroto

  committed
  7063c36

  Copy full SHA for 7063c36

• panic_in_result_fn: Extend to also check usages of [debug_]assert* macros

  Show description for e58c7dd
  

  dp304

  authored and

  ebroto

  committed
  e58c7dd

  Copy full SHA for e58c7dd

• Apply suggestions from code review

  Show description for bdad790
  

  dp304

  and

  ebroto

  committed
  bdad790

  Copy full SHA for bdad790

• Update reference file

  ebroto

  committed
  16d0e56

  Copy full SHA for 16d0e56

• Auto merge of rust-lang#6280 - dp304:assert_in_result_fn, r=ebroto

  Show description for 856f4f3
  bors

  committed
  856f4f3

  Copy full SHA for 856f4f3

Commits on Dec 8, 2020

• Auto merge of rust-lang#6330 - camsteffen:redundant-else, r=ebroto

  Show description for 50bca8a
  bors

  committed
  50bca8a

  Copy full SHA for 50bca8a

• Merge remote-tracking branch 'upstream/master' into sync-from-rust

  giraffate

  committed
  bd7f9c6

  Copy full SHA for bd7f9c6

• Auto merge of rust-lang#6432 - giraffate:sync-from-rust, r=flip1995

  Show description for f9fccbe
  bors

  committed
  f9fccbe

  Copy full SHA for f9fccbe

• Factor out some code in write.rs

  Show description for 3187cad
  ebroto

  committed
  3187cad

  Copy full SHA for 3187cad

• Auto merge of rust-lang#6367 - justjosias:6348-print-stderr, r=ebroto

  Show description for b02b0c7
  bors

  committed
  b02b0c7

  Copy full SHA for b02b0c7

Commits on Dec 9, 2020

• Auto merge of rust-lang#6188 - ebroto:primary_package, r=flip1995

  Show description for a2d9925
  bors

  committed
  a2d9925

  Copy full SHA for a2d9925

• Add a lint for maps with zero-sized values

  Show description for f77f1db
  

  korrat

  and

  ebroto

  committed
  f77f1db

  Copy full SHA for f77f1db

• Auto merge of rust-lang#6218 - korrat:master, r=ebroto

  Show description for 6c70133
  bors

  committed
  6c70133

  Copy full SHA for 6c70133

Commits on Dec 10, 2020

• Pin Clippy to a nightly

  

  ebroto

  authored and

  flip1995

  committed
  613333a

  Copy full SHA for 613333a

• Apply suggestions from PR review

  Show description for 2e8b00a
  

  ebroto

  authored and

  flip1995

  committed
  2e8b00a

  Copy full SHA for 2e8b00a

• Use new cache key

  

  ebroto

  authored and

  flip1995

  committed
  77a32eb

  Copy full SHA for 77a32eb

• Enable internal lints for every test in CI

  flip1995

  committed
  20d84fd

  Copy full SHA for 20d84fd

• Fix toolchain installation in workflows

  flip1995

  committed
  41cab83

  Copy full SHA for 41cab83

• Stop caching on CI

  Show description for 26dcbf5
  flip1995

  committed
  26dcbf5

  Copy full SHA for 26dcbf5

• Error in integration test, if required toolchain is not installed

  flip1995

  committed
  3f41fe2

  Copy full SHA for 3f41fe2

• Fix integration test runner

  flip1995

  committed
  836325e

  Copy full SHA for 836325e

• Lint wrong self convention in trait also

  ThibsG

  committed
  a6bb927

  Copy full SHA for a6bb927

• Common function to lint wrong self convention from impl and trait def

  ThibsG

  committed
  4af9382

  Copy full SHA for 4af9382

• Allow wrong_self_convention in use_self test for trait def

  ThibsG

  committed
  db98651

  Copy full SHA for db98651

• Update tests/ui/use_self.rs

  Show description for 1e0f85b
  

  ThibsG

  and

  ebroto

  committed
  1e0f85b

  Copy full SHA for 1e0f85b

• Add tests for unsized trait in wrong_self_convention lint

  ThibsG

  committed
  90a16e4

  Copy full SHA for 90a16e4

Commits on Dec 11, 2020

• add MSRV to more lints specified in rust-lang#6097

  Show description for a7cfffe
  suyashb95

  committed
  a7cfffe

  Copy full SHA for a7cfffe

• add instructions to include msrv in lints

  suyashb95

  committed
  8df11e4

  Copy full SHA for 8df11e4

• add test for missing_const_for_fn. fix test stderr

  suyashb95

  committed
  9f27b74

  Copy full SHA for 9f27b74

• Auto merge of rust-lang#6424 - Suyash458:master, r=flip1995

  Show description for 27fd6ed
  bors

  committed
  27fd6ed

  Copy full SHA for 27fd6ed

• Fix FP of manual_range_contains in const fn

  giraffate

  committed
  26c61c7

  Copy full SHA for 26c61c7

• Auto merge of rust-lang#6401 - ebroto:pin_to_a_nightly, r=ebroto

  Show description for baf5f2d
  bors

  committed
  baf5f2d

  Copy full SHA for baf5f2d

• Move binder for dyn to each list item

  jackh726

  committed
  30ef177

  Copy full SHA for 30ef177

Commits on Dec 12, 2020

• clone_double_ref: print reference type in lint message

  Show description for 0b145d6
  matthiaskrgr

  committed
  0b145d6

  Copy full SHA for 0b145d6

• clone_on_copy: show the type in the lint message

  Show description for b2cb6ff
  matthiaskrgr

  committed
  b2cb6ff

  Copy full SHA for b2cb6ff

• Rewrite update-all-references bash scripts in Rust

  Show description for 4bd9ed9
  phansch

  committed
  4bd9ed9

  Copy full SHA for 4bd9ed9

• Improve variable naming

  phansch

  committed
  41c562d

  Copy full SHA for 41c562d

• Feed the dog 🐕

  phansch

  committed
  b8501e1

  Copy full SHA for b8501e1

• Auto merge of rust-lang#6413 - phansch:bless, r=flip1995

  Show description for 18c5ea4
  bors

  committed
  18c5ea4

  Copy full SHA for 18c5ea4

• Auto merge of rust-lang#6382 - giraffate:fix_fp_in_manual_range_contains_when_const_fn, r=llogiq

  Show description for 3b89a67
  bors

  committed
  3b89a67

  Copy full SHA for 3b89a67

• Auto merge of rust-lang#6318 - camsteffen:article-description, r=Manishearth

  Show description for 89c282f
  bors

  committed
  89c282f

  Copy full SHA for 89c282f

Commits on Dec 13, 2020

• New internal lint: interning_defined_symbol

  

  Michael Wright

  committed
  3af09b8

  Copy full SHA for 3af09b8

• Fix dogfood errors

  

  Michael Wright

  committed
  a6aa0ac

  Copy full SHA for a6aa0ac

• Run 'cargo dev update_lints'

  

  Michael Wright

  committed
  64e630c

  Copy full SHA for 64e630c

• Auto merge of rust-lang#6442 - matthiaskrgr:clone-double-ref-ty, r=llogiq

  Show description for b7db5bf
  bors

  committed
  b7db5bf

  Copy full SHA for b7db5bf

• needless_borrow: print the type in the lint message

  Show description for cd2a62c
  matthiaskrgr

  committed
  cd2a62c

  Copy full SHA for cd2a62c

• Pass Clippy args also trough RUSTFLAGS

  ebroto

  committed
  cc96955

  Copy full SHA for cc96955

• Address comments from PR review

  Show description for f93d965
  ebroto

  committed
  f93d965

  Copy full SHA for f93d965

• Auto merge of rust-lang#6441 - ebroto:use_rustflags, r=flip1995

  Show description for 684f17e
  bors

  committed
  684f17e

  Copy full SHA for 684f17e

• Auto merge of rust-lang#6443 - matthiaskrgr:clone_on_copy_type, r=ebroto

  Show description for 1df2e38
  bors

  committed
  1df2e38

  Copy full SHA for 1df2e38

• Auto merge of rust-lang#6449 - matthiaskrgr:needless_borrow_ty, r=ebroto

  Show description for 6b2b357
  bors

  committed
  6b2b357

  Copy full SHA for 6b2b357

• NFC: clippy cargo dev: move generation of clap config into a function

  matthiaskrgr

  committed
  404c50f

  Copy full SHA for 404c50f

• clippy dev fmt: don't format if we have a local rustc repo enabled as path dependency via cargo dev ra-setup.

  Show description for 91fa25c
  matthiaskrgr

  committed
  91fa25c

  Copy full SHA for 91fa25c

• cargo dev: rename ra-setup to ra_setup to be in line with the other commands

  matthiaskrgr

  committed
  27dc565

  Copy full SHA for 27dc565

• Auto merge of rust-lang#6450 - matthiaskrgr:dont_format_local_repo, r=ebroto

  Show description for a642b42
  bors

  committed
  a642b42

  Copy full SHA for a642b42

• Removing false positive for the match_single_binding lint

  Show description for a37af06
  xFrednet

  committed
  a37af06

  Copy full SHA for a37af06

• Auto merge of rust-lang#6435 - xFrednet:5552-false-positive-match-single-binding, r=ebroto

  Show description for d924164
  bors

  committed
  d924164

  Copy full SHA for d924164

Commits on Dec 14, 2020

• Fix links in CONTRIBUTING.md

  giraffate

  committed
  426aba2

  Copy full SHA for 426aba2

• Auto merge of rust-lang#6451 - giraffate:update_contributing_md, r=llogiq

  Show description for 5b03834
  bors

  committed
  5b03834

  Copy full SHA for 5b03834

• bump pinned nightly from nightly-2020-12-09 to nightly-2020-12-14

  Show description for 8b1e9ed
  matthiaskrgr

  committed
  8b1e9ed

  Copy full SHA for 8b1e9ed

• Auto merge of rust-lang#6452 - matthiaskrgr:bump_nightly, r=flip1995

  Show description for 6c83e56
  bors

  committed
  6c83e56

  Copy full SHA for 6c83e56

• Improve warnings on incompatible options involving -Zinstrument-coverage

  Show description for 3043a7b
  richkadel

  committed
  3043a7b

  Copy full SHA for 3043a7b

Commits on Dec 15, 2020

• Convenience funcs for some_option.unwrap_or(...)

  Show description for ae288df
  richkadel

  committed
  ae288df

  Copy full SHA for ae288df

• Auto merge of rust-lang#78399 - vn-ki:gsgdt-graphviz, r=oli-obk

  Show description for 39aca5f
  bors

  committed
  39aca5f

  Copy full SHA for 39aca5f

• Handle fatal errors when parsing doctests

  ebroto

  committed
  39bcf8e

  Copy full SHA for 39bcf8e

• needless_doctest_main: add edition support

  ebroto

  committed
  41b5ebe

  Copy full SHA for 41b5ebe

Commits on Dec 16, 2020

• Remove unsafe code

  

  Michael Wright

  committed
  f732cc5

  Copy full SHA for f732cc5

• Auto merge of rust-lang#6448 - mikerite:interning_defined_symbol, r=Manishearth

  Show description for 142f0f5
  bors

  committed
  142f0f5

  Copy full SHA for 142f0f5

• Typo: std::fs::crate_dir -> std::fs::create_dir

  Dorumin

  authored
  1d6fac6

  Copy full SHA for 1d6fac6

Commits on Dec 17, 2020

• Auto merge of rust-lang#6461 - Dorumin:patch-1, r=Manishearth

  Show description for 5c00931
  bors

  committed
  5c00931

  Copy full SHA for 5c00931

• Rollup merge of rust-lang#79051 - LeSeulArtichaut:if-let-guard, r=matthewjasper

  Show description for 286e492
  JohnTitor

  authored
  286e492

  Copy full SHA for 286e492

• Apply suggestion from PR review

  ebroto

  committed
  bb68ec6

  Copy full SHA for bb68ec6

• Auto merge of rust-lang#79945 - jackh726:existential_trait_ref, r=nikomatsakis

  Show description for 8e9a538
  bors

  committed
  8e9a538

  Copy full SHA for 8e9a538

Commits on Dec 18, 2020

• make needless_update ignore non_exhaustive structs

  ahouts

  committed
  1eb7608

  Copy full SHA for 1eb7608

• add more lints to msrv docs

  suyashb95

  committed
  920c9a4

  Copy full SHA for 920c9a4

• Auto merge of rust-lang#6458 - ebroto:6022_parse_doctest, r=Manishearth

  Show description for 88323e8
  bors

  committed
  88323e8

  Copy full SHA for 88323e8

• Auto merge of rust-lang#6465 - Suyash458:master, r=flip1995

  Show description for 896d82f
  bors

  committed
  896d82f

  Copy full SHA for 896d82f

• Renamed the good first issue label for rustbot

  Show description for 1f58c2b
  xFrednet

  committed
  1f58c2b

  Copy full SHA for 1f58c2b

• Auto merge of rust-lang#6468 - xFrednet:0000-rename-good-first-issue-for-rustbot, r=flip1995

  Show description for 9be7045
  bors

  committed
  9be7045

  Copy full SHA for 9be7045

• Renamed the good first issue label in CONTRIBUTING.md

  xFrednet

  committed
  ced54f2

  Copy full SHA for ced54f2

• Auto merge of rust-lang#6470 - xFrednet:0000-rename-good-first-issue-in-docs, r=flip1995

  Show description for a898df4
  bors

  committed
  a898df4

  Copy full SHA for a898df4

Commits on Dec 19, 2020

• remove example

  ahouts

  committed
  a24c6f1

  Copy full SHA for a24c6f1

• Auto merge of rust-lang#6464 - ahouts:make-needless_update-ignore-non_exhaustive-structs, r=phansch

  Show description for 0718eeb
  bors

  committed
  0718eeb

  Copy full SHA for 0718eeb

• Fix blessing of new reference files

  Show description for dfb4ea5
  phansch

  committed
  dfb4ea5

  Copy full SHA for dfb4ea5

• More rebinds

  jackh726

  committed
  f00b6ac

  Copy full SHA for f00b6ac

• Auto merge of rust-lang#6471 - phansch:fix-bless, r=flip1995

  Show description for 73feb31
  bors

  committed
  73feb31

  Copy full SHA for 73feb31

• UI Tests: Separate suspicious_else_formatting tests

  phansch

  committed
  8ddf4ce

  Copy full SHA for 8ddf4ce

• Auto merge of rust-lang#6473 - phansch:split-up-ui-test, r=flip1995

  Show description for 0904f54
  bors

  committed
  0904f54

  Copy full SHA for 0904f54

• Adapted the website search for better matching

  Show description for 2814ee4
  xFrednet

  committed
  2814ee4

  Copy full SHA for 2814ee4

• Auto merge of rust-lang#6316 - ThibsG:WrongSelfConventionTraitDef, r=ebroto

  Show description for 9f9e9f7
  bors

  committed
  9f9e9f7

  Copy full SHA for 9f9e9f7

• Auto merge of rust-lang#6477 - xFrednet:0000-enable-search-with-dashes, r=ebroto

  Show description for 12a35ab
  bors

  committed
  12a35ab

  Copy full SHA for 12a35ab

Commits on Dec 20, 2020

• Merge remote-tracking branch 'upstream/master' into rustup

  flip1995

  committed
  883a3d1

  Copy full SHA for 883a3d1

• Bump nightly to 2020-12-20

  flip1995

  committed
  53d6e0c

  Copy full SHA for 53d6e0c

• Auto merge of rust-lang#6482 - flip1995:rustup, r=flip1995

  Show description for 4911ab1
  bors

  committed
  4911ab1

  Copy full SHA for 4911ab1

• Merge commit '4911ab124c481430672a3833b37075e6435ec34d' into clippyup

  flip1995

  committed
  520761a

  Copy full SHA for 520761a