Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Permit standalone generic parameters as const generic arguments in macros #79164

Merged
merged 2 commits into from
Nov 19, 2020
Merged

Permit standalone generic parameters as const generic arguments in macros #79164

merged 2 commits into from
Nov 19, 2020

Conversation

varkor
Copy link
Member

@varkor varkor commented Nov 18, 2020

Fixes #79127.

r? @petrochenkov

@varkor varkor added A-const-generics Area: const generics (parameters and arguments) F-const_generics `#![feature(const_generics)]` F-min_const_generics labels Nov 18, 2020
@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Nov 18, 2020
@varkor varkor force-pushed the unbraced-single-segment-const-arguments branch from c63aa1c to 85bc953 Compare November 18, 2020 13:17
@jyn514 jyn514 added T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. A-macros Area: All kinds of macros (custom derive, macro_rules!, proc macros, ..) labels Nov 18, 2020
@petrochenkov
Copy link
Contributor

@bors r+

@bors
Copy link
Contributor

bors commented Nov 18, 2020

📌 Commit 85bc953 has been approved by petrochenkov

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Nov 18, 2020
Dylan-DPC-zz pushed a commit to Dylan-DPC-zz/rust that referenced this pull request Nov 19, 2020
@Dylan-DPC
Rollup merge of rust-lang#79164 - varkor:unbraced-single-segment-cons…
59e475f 
…t-arguments, r=petrochenkov

Permit standalone generic parameters as const generic arguments in macros

Fixes rust-lang#79127.

r? `@petrochenkov`
@Dylan-DPC-zz Dylan-DPC-zz mentioned this pull request Nov 19, 2020
Closed
Dylan-DPC-zz pushed a commit to Dylan-DPC-zz/rust that referenced this pull request Nov 19, 2020
@Dylan-DPC
Rollup merge of rust-lang#79164 - varkor:unbraced-single-segment-cons…
37e64af 
…t-arguments, r=petrochenkov

Permit standalone generic parameters as const generic arguments in macros

Fixes rust-lang#79127.

r? ``@petrochenkov``
@Dylan-DPC-zz Dylan-DPC-zz mentioned this pull request Nov 19, 2020
Closed
@Dylan-DPC-zz Dylan-DPC-zz mentioned this pull request Nov 19, 2020
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request Nov 19, 2020
@bors
Auto merge of rust-lang#79200 - Dylan-DPC:rollup-su689pq, r=Dylan-DPC
fe98231 
Rollup of 14 pull requests

Successful merges:

 - rust-lang#78961 (Make bad "rust-call" arguments no longer ICE)
 - rust-lang#79082 (Improve the diagnostic for when an `fn` contains qualifiers inside an `extern` block.)
 - rust-lang#79090 (libary: Forward compiler-builtins "asm"  and "mangled-names" feature)
 - rust-lang#79094 (Add //ignore-macos to pretty-std-collections.rs)
 - rust-lang#79101 (Don't special case constant operands when lowering intrinsics)
 - rust-lang#79102 (Add two regression tests)
 - rust-lang#79110 (Remove redundant notes in E0275)
 - rust-lang#79116 (compiletest: Fix a warning in debuginfo tests on windows-gnu)
 - rust-lang#79117 (add optimization fuel checks to some mir passes)
 - rust-lang#79147 (Highlight MIR as Rust on GitHub)
 - rust-lang#79149 (Move capture lowering from THIR to MIR)
 - rust-lang#79155 (fix handling the default config for profiler and sanitizers)
 - rust-lang#79156 (Allow using `download-ci-llvm` from directories other than the root)
 - rust-lang#79164 (Permit standalone generic parameters as const generic arguments in macros)

Failed merges:

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit b5fffdc into rust-lang:master Nov 19, 2020
@rustbot rustbot added this to the 1.50.0 milestone Nov 19, 2020
@lcnr lcnr mentioned this pull request Dec 11, 2021
Closed
16 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@petrochenkov petrochenkov

Labels
A-const-generics Area: const generics (parameters and arguments) A-macros Area: All kinds of macros (custom derive, macro_rules!, proc macros, ..) F-const_generics `#![feature(const_generics)]` S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
1.50.0
Development

Successfully merging this pull request may close these issues.

cannot use const params from macros as const args without braces
6 participants
@varkor @petrochenkov @bors @rust-highfive @jyn514 @rustbot