Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Trivial fixes to bitwise operator documentation #78620

Merged
merged 3 commits into from
Nov 2, 2020
Merged

Trivial fixes to bitwise operator documentation #78620

merged 3 commits into from
Nov 2, 2020

Conversation

gabhijit
Copy link
Contributor

@gabhijit gabhijit commented Nov 1, 2020 •
edited by jyn514
Loading

Added fixes to documentation of BitAnd, BitOr, BitXor and
BitAndAssign, where the documentation for implementation on
Vector<bool> was using logical operators in place of the bitwise
operators.

r? @steveklabnik
Closes #78619

@gabhijit
Trivial fixes to bitwise operator documentation
66d68cd 
Added fixes to documentation of `BitAnd`, `BitOr`, `BitXor` and
`BitAndAssign`, where the documentation for implementation on
`Vector<bool>` was using logical operators in place of the bitwise
operators.

r? @steveklabnik
cc rust-lang#78619
@rust-highfive
Copy link
Collaborator

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @steveklabnik (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see the contribution instructions for more information.

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Nov 1, 2020
m-ou-se
m-ou-se reviewed Nov 1, 2020
View reviewed changes
library/core/src/ops/bit.rs Outdated Show resolved Hide resolved
@m-ou-se
Copy link
Member

m-ou-se commented Nov 1, 2020

Thanks!

I personally don't really feel strongly about && vs & and || vs |, but the xor example is a clear improvement, and so is the formatting.

@bors r+ rollup

@bors
Copy link
Contributor

bors commented Nov 1, 2020

📌 Commit d422e24 has been approved by m-ou-se

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Nov 1, 2020
m-ou-se added a commit to m-ou-se/rust that referenced this pull request Nov 1, 2020
@m-ou-se
Rollup merge of rust-lang#78620 - gabhijit:bitops_doc_fix, r=m-ou-se
c43eb4a 
Trivial fixes to bitwise operator documentation

Added fixes to documentation of `BitAnd`, `BitOr`, `BitXor` and
`BitAndAssign`, where the documentation for implementation on
`Vector<bool>` was using logical operators in place of the bitwise
operators.

r? @steveklabnik
cc rust-lang#78619
@m-ou-se m-ou-se mentioned this pull request Nov 1, 2020
Closed
@camelid camelid added the A-docs Area: Documentation for any part of the project, including the compiler, standard library, and tools label Nov 1, 2020
@JohnTitor JohnTitor mentioned this pull request Nov 2, 2020
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request Nov 2, 2020
@bors
Auto merge of rust-lang#78661 - JohnTitor:rollup-er2isja, r=JohnTitor
4051473 
Rollup of 5 pull requests

Successful merges:

 - rust-lang#78606 (Clarify handling of final line ending in str::lines())
 - rust-lang#78610 (Do not remove tokens before AST json serialization)
 - rust-lang#78620 (Trivial fixes to bitwise operator documentation)
 - rust-lang#78627 (Point out that total_cmp is no strict superset of partial comparison)
 - rust-lang#78637 (Add fetch_update methods to AtomicBool and AtomicPtr)

Failed merges:

r? `@ghost`
@bors bors merged commit 7baf48f into rust-lang:master Nov 2, 2020
@rustbot rustbot added this to the 1.49.0 milestone Nov 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@m-ou-se m-ou-se m-ou-se left review comments

Assignees

@steveklabnik steveklabnik

Labels
A-docs Area: Documentation for any part of the project, including the compiler, standard library, and tools S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Milestone
1.49.0
Development

Successfully merging this pull request may close these issues.

Trivial documentation issue with core::ops::Bit{And|Or|Xor}
7 participants
@gabhijit @rust-highfive @m-ou-se @bors @steveklabnik @camelid @rustbot