Refactor how SwitchInt stores jump targets #77796
Conversation
|
r? @eddyb (rust_highfive has picked a reviewer for you, use r? to override) |
|
@bors try @rust-timer queue r? @oli-obk |
|
Awaiting bors try build completion |
|
⌛ Trying commit 432535d with merge f75713278ef412b926ff605fed784633ba5d6092... |
|
☀️ Try build successful - checks-actions, checks-azure |
|
Queued f75713278ef412b926ff605fed784633ba5d6092 with parent cae8bc1, future comparison URL. |
|
Finished benchmarking try commit (f75713278ef412b926ff605fed784633ba5d6092): comparison url. Benchmarking this pull request likely means that it is perf-sensitive, so we're automatically marking it as not fit for rolling up. Please note that if the perf results are neutral, you should likely undo the rollup=never given below by specifying Importantly, though, if the results of this run are non-neutral do not roll this PR up -- it will mask other regressions or improvements in the roll up. @bors rollup=never |
This allows building common SwitchTargets (eg. for `if`s) without allocation.
|
Looks like no noticeable change so far, good. Let's try using |
|
@bors try @rust-timer queue |
|
Awaiting bors try build completion |
|
⌛ Trying commit 9a47f74 with merge 70f6dc489a31b5239cdff8395134265d0d6452cc... |
|
☀️ Try build successful - checks-actions, checks-azure |
|
Queued 70f6dc489a31b5239cdff8395134265d0d6452cc with parent 790d19c, future comparison URL. |
|
Finished benchmarking try commit (70f6dc489a31b5239cdff8395134265d0d6452cc): comparison url. Benchmarking this pull request likely means that it is perf-sensitive, so we're automatically marking it as not fit for rolling up. Please note that if the perf results are neutral, you should likely undo the rollup=never given below by specifying Importantly, though, if the results of this run are non-neutral do not roll this PR up -- it will mask other regressions or improvements in the roll up. @bors rollup=never |
|
Hmm, instructions went down, but cycles and clocks went up. Not sure if that's just noise. |
|
cycles and clocks are always the least reliable. The change lgtm and without you mentioning it I wouldn't even have looked at anything but instructions. @bors r+ |
|
📌 Commit 9a47f74 has been approved by |
|
☀️ Test successful - checks-actions, checks-azure |
|
Perf results after landing are about as expected; I agree with @oli-obk that I would not want to change anything here and I think investigating is not warranted to prioritize right now. |
…=oli-obk Refactor how SwitchInt stores jump targets Closes rust-lang#65693
Closes #65693