rustdoc: fix min_const_generics with ty::Param #76297
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jyn514
reviewed
Sep 3, 2020
Comment on lines
+1371
to
+1372
| // `const_eval_poly` tries to to first substitute generic parameters which | ||
| // results in an ICE while manually constructing the constant and using `eval` |
There was a problem hiding this comment.
Maybe this should also fix the ICE to return an error?
There was a problem hiding this comment.
The underlying ICE in const_eval_poly can't really be fixed. It is a weird sideeffect of how min_const_generics works.
It might make sense to check for ConstKind::Param in const_eval_raw but I personally don't think that that would be a cleaner solution 🤔
|
@bors r+ rollup |
|
📌 Commit ccf1f58 has been approved by |
|
⌛ Testing commit ccf1f58 with merge 67d6720668a1a2464364994e8c94791a49ee16db... |
|
💔 Test failed - checks-actions |
|
|
Cc @oli-obk (seems like an interesting case where |
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Sep 12, 2020
Rollup of 7 pull requests Successful merges: - rust-lang#76114 (Add saturating methods for `Duration`) - rust-lang#76297 (rustdoc: fix min_const_generics with ty::Param) - rust-lang#76484 (Add MaybeUninit::assume_init_drop.) - rust-lang#76530 (Eliminate mut reference UB in Drop impl for Rc<T>) - rust-lang#76583 (Update `std::os` module documentation.) - rust-lang#76599 (Finish off revisions for const generics UI tests.) - rust-lang#76615 (Add missing examples on binary core traits) Failed merges: r? `@ghost`
16 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #75913
r? @varkor cc @jyn514