Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make doctests of Ipv4Addr::from(u32) easier to read #75175

Merged
merged 1 commit into from
Aug 7, 2020

Conversation

tesuji
Copy link
Contributor

@tesuji tesuji commented Aug 5, 2020

There are many zeroes in 0x0d0c0b0au32 which makes it hard to read.

@rust-highfive
Copy link
Collaborator

r? @hanna-kruppe

(rust_highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Aug 5, 2020
@tesuji tesuji force-pushed the doctest-ipv4-fromu32 branch from 4cb5727 to 725d37c Compare August 5, 2020 05:31
@tesuji
Copy link
Contributor Author

tesuji commented Aug 5, 2020

It seems that Hanna is busy. r? @cuviper

@rust-highfive rust-highfive assigned cuviper and unassigned hanna-kruppe Aug 5, 2020
@cuviper
Copy link
Member

cuviper commented Aug 6, 2020

@bors r+ rollup

@bors
Copy link
Contributor

bors commented Aug 6, 2020

📌 Commit 725d37c has been approved by cuviper

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Aug 6, 2020
bors added a commit to rust-lang-ci/rust that referenced this pull request Aug 7, 2020
Rollup of 12 pull requests

Successful merges:

 - rust-lang#74888 (compiletest: ignore-endian-big, fixes rust-lang#74829, fixes rust-lang#74885)
 - rust-lang#75175 (Make doctests of Ipv4Addr::from(u32) easier to read)
 - rust-lang#75179 (Remove unused FromInner impl for Ipv4Addr)
 - rust-lang#75181 (Fix typo in  `librustc_feature/active.rs`)
 - rust-lang#75183 (Label rustfmt toolstate issues with A-rustfmt)
 - rust-lang#75188 (Handle fieldless tuple structs in diagnostic code)
 - rust-lang#75190 (Clean up E0746 explanation)
 - rust-lang#75210 (Change the type of `AssertModuleSource::available_cgus`.)
 - rust-lang#75211 (Note about endianness of returned value of {integer}::from_be_bytes and friends)
 - rust-lang#75217 (Clean up E0747 explanation)
 - rust-lang#75232 (Fix typo "TraitObligatiom" -> "TraitObligation")
 - rust-lang#75236 (Fix typo "biset" -> "bitset")

Failed merges:

r? @ghost
@bors bors merged commit c9c7048 into rust-lang:master Aug 7, 2020
@tesuji tesuji deleted the doctest-ipv4-fromu32 branch August 7, 2020 10:20
@cuviper cuviper added this to the 1.47.0 milestone May 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants