Make diagnostics clearer for ? operator
#75029
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JohnTitor
commented
Aug 1, 2020
Comment on lines
+7
to
+8
| = note: `?` operator cannot convert from `isize` to `std::result::Result<isize, ()>` | ||
| = help: `?` operator unwraps `Result` or `Option` and propagates its `Err` or `None` |
There was a problem hiding this comment.
In my opinion this last note is not necessary. The clarification with concrete types of the first note should be enough, and people may be using the try_trait feature with custom types where this won't apply.
Though I can see this as The explanation that makes it clear for some people.
There was a problem hiding this comment.
I agree, I feel the second note is probably unnecessary, no-one is likely to try to use ? without knowing that Result and Option are supported.
|
☔ The latest upstream changes (presumably #74862) made this pull request unmergeable. Please resolve the merge conflicts. |
estebank
reviewed
Sep 4, 2020
Comment on lines
+11
to
+12
| LL | let y: u32 = x?.try_into().unwrap(); | ||
| | ^^^^^^^^^^^^^^^^^^^^^^ |
There was a problem hiding this comment.
The suggestion seems to be using the incorrect Span. It should be replacing the ? with the new code.
|
Closing this due to inactivity. |
JohnTitor
added a commit
to JohnTitor/rust
that referenced
this pull request
Sep 17, 2021
Make diagnostics clearer for `?` operators Re-submission of rust-lang#75029, fixes rust-lang#71309 This also revives the `content` methods removed by rust-lang#83185. r? `@estebank`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #71309
r? @estebank