Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Teach bootstrap install and dist commands about TargetSelection #74495

Merged
merged 1 commit into from
Jul 20, 2020
Merged

Teach bootstrap install and dist commands about TargetSelection #74495

merged 1 commit into from
Jul 20, 2020

Conversation

shepmaster
Copy link
Member

With this, we can now use a target JSON file to build a
cross-compiler:

x.py install --host ../aarch64-apple-darwin.json --target aarch64-apple-darwin

r? @Mark-Simulacrum

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jul 19, 2020
@Mark-Simulacrum
Copy link
Member

Looks like you'll need to rustfmt: https://github.com/rust-lang/rust/pull/74495/checks?check_run_id=886036950#step:22:1573

@Mark-Simulacrum
Copy link
Member

r=me with that fixed though

@shepmaster
Teach bootstrap install and dist commands about TargetSelection
57614da 
With this, we can now use a target JSON file to build a
cross-compiler:

```
x.py install --host ../aarch64-apple-darwin.json --target aarch64-apple-darwin
```
@shepmaster shepmaster force-pushed the bootstrap-dist-target-files branch from f65f6c1 to 57614da Compare July 19, 2020 17:04
@shepmaster
Copy link
Member Author

@bors r=@Mark-Simulacrum

@bors
Copy link
Contributor

bors commented Jul 19, 2020

📌 Commit 57614da has been approved by Mark-Simulacrum

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jul 19, 2020
@bors
Copy link
Contributor

bors commented Jul 19, 2020

⌛ Testing commit 57614da with merge 56f8feaaabfae6c32d13f56f9c7bf8a08f3eb7d7...

Manishearth added a commit to Manishearth/rust that referenced this pull request Jul 19, 2020
@Manishearth
Rollup merge of rust-lang#74495 - shepmaster:bootstrap-dist-target-fi…
59617e4 
…les, r=Mark-Simulacrum

Teach bootstrap install and dist commands about TargetSelection

With this, we can now use a target JSON file to build a
cross-compiler:

```
x.py install --host ../aarch64-apple-darwin.json --target aarch64-apple-darwin
```

r? @Mark-Simulacrum
@Manishearth Manishearth mentioned this pull request Jul 19, 2020
Closed
@Manishearth
Copy link
Member

@bors retry yoeld

@Manishearth
Copy link
Member

@abors retry yield

@Manishearth
Copy link
Member

@bors retry yield

@bors
Copy link
Contributor

bors commented Jul 19, 2020

⌛ Testing commit 57614da with merge 845b434786603fd2a2776f59c0f385a845f9b34a...

@bors
Copy link
Contributor

bors commented Jul 19, 2020

💔 Test failed - checks-azure

@bors bors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Jul 19, 2020
@ehuss
Copy link
Contributor

ehuss commented Jul 19, 2020

@bors retry
Azure error:

error: failed to get `cc` as a dependency of package `bootstrap v0.0.0 (D:\a\1\s\src\bootstrap)`

Caused by:
  failed to fetch `https://github.com/rust-lang/crates.io-index`

Caused by:
  error inflating zlib stream; class=Zlib (5)

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jul 19, 2020
@bors
Copy link
Contributor

bors commented Jul 19, 2020

⌛ Testing commit 57614da with merge 2c21a6f...

@bors
Copy link
Contributor

bors commented Jul 20, 2020

☀️ Test successful - checks-actions, checks-azure
Approved by: Mark-Simulacrum
Pushing 2c21a6f to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Jul 20, 2020
@bors bors merged commit 2c21a6f into rust-lang:master Jul 20, 2020
@ehuss ehuss mentioned this pull request Jul 23, 2020
Closed
@cuviper cuviper added this to the 1.47.0 milestone May 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@Mark-Simulacrum Mark-Simulacrum

Labels
merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Milestone
1.47.0
Development

Successfully merging this pull request may close these issues.
7 participants
@shepmaster @Mark-Simulacrum @bors @Manishearth @ehuss @cuviper @rust-highfive