Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add #24949 assoc constant static recursion test #71657

Merged
merged 1 commit into from
Apr 29, 2020

Conversation

Daniel-Worrall
Copy link
Contributor

@Daniel-Worrall Daniel-Worrall commented Apr 28, 2020

Closes #24949

Forced tidy fixes

@rust-highfive
Copy link
Collaborator

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @nikomatsakis (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see the contribution instructions for more information.

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Apr 28, 2020
@Dylan-DPC-zz
Copy link

r? @estebank

@estebank
Copy link
Contributor

@bors r+ rollup

@bors
Copy link
Contributor

bors commented Apr 29, 2020

📌 Commit e91c3a1 has been approved by estebank

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Apr 29, 2020
bors added a commit to rust-lang-ci/rust that referenced this pull request Apr 29, 2020
Rollup of 5 pull requests

Successful merges:

 - rust-lang#71217 (Suggest `;` or assignment to drop borrows in tail exprs)
 - rust-lang#71286 (Add regression test for rust-lang#69654)
 - rust-lang#71296 (Change wording on read_vectored docs)
 - rust-lang#71654 (Update link to unstable book for llvm_asm macro)
 - rust-lang#71657 (Add rust-lang#24949 assoc constant static recursion test)

Failed merges:

r? @ghost
@bors bors merged commit 878e928 into rust-lang:master Apr 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Associated const references using UFCS can bypass check_static_recursion
6 participants