Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Prepare for LLVM 10 upgrade #70163

Merged
merged 5 commits into from
Mar 24, 2020
Merged

Prepare for LLVM 10 upgrade #70163

merged 5 commits into from
Mar 24, 2020

Conversation

nikic
Copy link
Contributor

@nikic nikic commented Mar 19, 2020

This is #67759 minus the submodule update.

  • Fix two compatibility issues in the rustllvm wrapper.
  • Update data layout strings in tests.
  • Fix LLVM version comparison (this become a problem because the major version has two digits now).

r? @cuviper

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Mar 19, 2020
@cuviper
Copy link
Member

cuviper commented Mar 19, 2020

Thanks!

@bors r+

@bors
Copy link
Contributor

bors commented Mar 19, 2020

📌 Commit 497f879 has been approved by cuviper

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Mar 19, 2020
@bors
Copy link
Contributor

bors commented Mar 24, 2020

⌛ Testing commit 497f879 with merge 374ab25...

@bors
Copy link
Contributor

bors commented Mar 24, 2020

☀️ Test successful - checks-azure
Approved by: cuviper
Pushing 374ab25 to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Mar 24, 2020
@bors bors merged commit 374ab25 into rust-lang:master Mar 24, 2020
@cuviper cuviper mentioned this pull request Apr 26, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@cuviper cuviper

Labels
merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@nikic @cuviper @bors @rust-highfive