Move diagnostics code out of the critical path #65295
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
r=me assuming it fixes the problem. @bors try @rust-timer queue |
|
Awaiting bors try build completion |
|
⌛ Trying commit 5bb0a03 with merge 5647d23873740a0c1f9af983a05dd1d0d912c757... |
|
☀️ Try build successful - checks-azure |
|
Queued 5647d23873740a0c1f9af983a05dd1d0d912c757 with parent 898f36c, future comparison URL. |
|
Finished benchmarking try commit 5647d23873740a0c1f9af983a05dd1d0d912c757, comparison URL. |
|
This looks like it completely reverses the regression, yay! |
|
@bors r=nnethercote |
|
📌 Commit 5bb0a03 has been approved by |
Centril
added a commit
to Centril/rust
that referenced
this pull request
Oct 13, 2019
Move diagnostics code out of the critical path Follow up to rust-lang#65077. r? @nnethercote
bors
added a commit
that referenced
this pull request
Oct 13, 2019
Rollup of 13 pull requests Successful merges: - #65039 (Document missing deny by default lints) - #65069 (Implement Clone::clone_from for VecDeque) - #65165 (Improve docs on some char boolean methods) - #65248 (Suggest `if let` on `let` refutable binding) - #65250 (resolve: fix error title regarding private constructors) - #65295 (Move diagnostics code out of the critical path) - #65320 (Report `CONST_ERR` lint in external macros) - #65327 (replace the hand-written binary search with the library one) - #65339 (do not reference LLVM for our concurrency memory model) - #65357 (syntax: simplify maybe_annotate_with_ascription) - #65358 (simplify maybe_stage_features) - #65359 (simplify integer_lit) - #65360 (mbe: reduce panictry! uses.) Failed merges: r? @ghost
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow up to #65077.
r? @nnethercote