Various cleanups to save analysis #63055
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This extracts the core visiting logic
Xanewok
reviewed
Jul 28, 2019
| DumpVisitor { | ||
| tcx: save_ctxt.tcx, | ||
| save_ctxt, | ||
| dumper, | ||
| span: span_utils, | ||
| cur_scope: CRATE_NODE_ID, |
There was a problem hiding this comment.
Wait, that's weird. So it was unused all along?
Xanewok
approved these changes
Jul 28, 2019
| DumpVisitor { | ||
| tcx: save_ctxt.tcx, | ||
| save_ctxt, | ||
| dumper, | ||
| span: span_utils, | ||
| cur_scope: CRATE_NODE_ID, |
|
Er, does it have to be a regular comment? @bors r+ rollup |
|
📌 Commit 5ff0856 has been approved by |
Centril
added a commit
to Centril/rust
that referenced
this pull request
Jul 29, 2019
…-2, r=Xanewok Various cleanups to save analysis
bors
added a commit
that referenced
this pull request
Jul 29, 2019
Rollup of 6 pull requests Successful merges: - #62809 (rustc: Update wasm32 support for LLVM 9) - #63055 (Various cleanups to save analysis) - #63076 (Miri: fix determining size of an "extra function" allocation) - #63077 (cleanup: Remove some language features related to built-in macros) - #63086 (Ignore test cases that are not supported by vxWorks) - #63092 (Update `impl Trait` gate issues) Failed merges: r? @ghost
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.