Hide trait default methods

[GuillaumeGomez]

Fixes #62499.

However, the question remains: do we want to extend it to this point or not?

r? @QuietMisdreavus

[wirelessringo]

Ping from triage. @QuietMisdreavus any updates on this? Thanks.

[GuillaumeGomez]

cc @ollie27

[JohnTitor]

Ping from triage: @QuietMisdreavus do you have time to review?

[fmckeogh]

Second ping from triage! Per procedure a new reviewer from the rustic team will be assigned.

r? @onur

[GuillaumeGomez]

r? @Mark-Simulacrum

[Alexendoo]

Ping from triage, any updates @Mark-Simulacrum?

[Mark-Simulacrum]

From a code perspective my only concern is that I'm not quite sure if this will affect overridden defaults (i.e., the trait method has a default impl but the impl Trait for Foo also implements that method); if that works as before and is shown then I think the code is fine by me.

From a policy perspective, probably the best approach here is to FCP the change? I'm not sure if rustdoc team has a firm policy in place. If you think it's fine to just land this without team approval then I'm fine with that, r=me.

[GuillaumeGomez]

Normally the tests should have checked that the overwrote methods with documentation are not hidden. Unless I missed something? Also, we only apply FCP for "big" changes, this one is pretty small in itself. That'd maybe deserve a talk when other rustdoc members are back. Meanwhile I'll r+ this PR but don't hesitate to r- if you feel like we should wait or anything seems not good and thanks for the review!

@bors: r=Mark-Simulacrum rollup

[bors]

📌 Commit f7656b6 has been approved by Mark-Simulacrum