Stable non-aio changesets (mostly channel refactoring) #613
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This will allow us to more easily clone channels from native code.
This lets native code more easily destroy channels since directly deleting a channel is not always the right way to destroy it.
The macro with the extra dtor parameter is intended for structures like rust_chan which may not necessarily delete themselves when the ref count becomes 0. This functionality will be used in an upcoming changeset.
If the channel is associated with a port then the destructor will assert. Additionally, destruction of the object is not always appropriate. This brings the deref() method into sync with the behavior of generated rust code which only invokes destroy() once the reference count goes to 0.
|
Merged. Thanks! |
keeperofdakeys
pushed a commit
to keeperofdakeys/rust
that referenced
this pull request
Dec 12, 2017
Openbsd kqueue The PR supersede rust-lang#613 to add exception on the testsuite.
marysaka
pushed a commit
to sunriseos/rust
that referenced
this pull request
Oct 20, 2019
This commit stabilizes the wasm32 memory-related intrinsics, as specified in rust-lang#56292. The old intrinsics were removed and the current intrinsics were updated in place, but it's the last breaking change!
ZuseZ4
added a commit
to EnzymeAD/rust
that referenced
this pull request
Mar 7, 2023
celinval
added a commit
to celinval/rust-dev
that referenced
this pull request
Jun 4, 2024
…) (rust-lang#615) When the crate contains a build script, cargo compiles the build script first without the RUSTFLAGS. Thus, we cannot use rmc-rustc directly, or it will try to compile the build script with rmc enabled. We then fail to generate the script binary. * Add --build-target to cargo rmc
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I can push these directly but I thought you might want to look over them first.