Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rustbuild: Simplify debuginfo configuration (take 2) #60968

Closed
wants to merge 1 commit into from
Closed

rustbuild: Simplify debuginfo configuration (take 2) #60968

wants to merge 1 commit into from

Conversation

petrochenkov
Copy link
Contributor

Same as #60568, except that

  • The old logic of partitioning into rustc/std/tools/tests is used.
  • The old defaults are kept (debuginfo-level only provides default for rustc and std, tools and tests need to enable debuginfo separately).

Enough to close #52179
r? @Mark-Simulacrum

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label May 19, 2019
@petrochenkov petrochenkov mentioned this pull request May 19, 2019
Merged
@petrochenkov
Copy link
Contributor Author

The wasm test (#60568 (comment)) still fails, weird.
I'll investigate.

@Mark-Simulacrum
Copy link
Member

Presuming wasm test is the reason you filed a new PR, probably makes sense to just fix in the first one?

@petrochenkov petrochenkov deleted the debi2 branch June 5, 2019 16:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@Mark-Simulacrum Mark-Simulacrum

Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

config.toml: debuginfo option documentation is confusing
3 participants
@petrochenkov @Mark-Simulacrum @rust-highfive