-
Notifications
You must be signed in to change notification settings - Fork 13.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bootstrap x86_64 musl by itself #60240
Conversation
@bors: try Nice! |
⌛ Trying commit edb396d with merge a90f8373dc60c0a5f657a8c48011deb357a90671... |
The job Click to expand the log.
I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact |
💔 Test failed - checks-travis |
@bors: retry |
Bootstrap x86_64 musl by itself It should slightly reduce build time and prepares ground for musl native tests. NOTE: I haven't tested artifacts yet (only the build). Can I have double try? r? @alexcrichton
☀️ Try build successful - checks-travis |
Not really an improvement, I'll check artifacts and log tomorrow. |
I tested it in Alpine and Ubuntu:14.04 containers and found no issues. Build time compared to normal (r+) jobs decreased only a little. There are less compilers build but everything takes longer. I don't know whether try builds are generally slower, musl toolchain is slower or sccache has to fill. Recent musl releases gained various optimisations, I can upgrade and see how it performs. |
That's still relatively close to the 2h limit and it makes sense to me in that it compiles less so it'll eventually be faster. Would you want to go ahead and land this or should we wait for more performance investigations of glibc vs musl? |
I think newer musl version could cut off few more minute but it's not that big deal and I'll bump musl anyway if I get guard pages to work. Dropped travis commit, it's ready to go. |
@bors: r+ |
📌 Commit d402415 has been approved by |
Bootstrap x86_64 musl by itself It should slightly reduce build time and prepares ground for musl native tests. NOTE: I haven't tested artifacts yet (only the build). Can I have double try? r? @alexcrichton
☀️ Test successful - checks-travis, status-appveyor |
Looking at build time on |
It should slightly reduce build time and prepares ground for musl native tests.
NOTE: I haven't tested artifacts yet (only the build).
Can I have double try?
r? @alexcrichton