[CI] Update GCC in the dist-linux builders #58416
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This also updates dist-i686-linux, since it borrows the same scripts. While we're at it, update llvm+clang+lld to llvm-project 8.0.0-rc2.
cuviper
commented
Feb 13, 2019
| - Target options > Target Architecture = arm | ||
| - Target options > Architecture level = armv6 -- (+) | ||
| - Target options > Floating point = software (no FPU) -- (\*) | ||
| - Operating System > Target OS = linux | ||
| - Operating System > Linux kernel version = 3.2.72 -- Precise kernel | ||
| - C-library > glibc version = 2.14.1 | ||
| - C compiler > gcc version = 4.9.3 | ||
| - C-library > glibc version = 2.16.0 |
There was a problem hiding this comment.
Note, the arm builders were already configured for glibc 2.16.0, but the README wasn't in sync.
|
📌 Commit adb54c2 has been approved by |
|
In-between-rollups-filler, @bors p=1 |
|
⌛ Testing commit adb54c2 with merge f1124a1386ea71ff7ca6e354761e3f97c1d947d4... |
|
The job Click to expand the log.I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact |
|
💔 Test failed - checks-travis |
|
@bors: retry |
|
@bors p=187 rollup fairness |
|
⌛ Testing commit adb54c2 with merge b196a004f22a522dae16d794aeae64179ebfd95f... |
|
💔 Test failed - checks-travis |
|
Your PR failed on Travis (raw log). Through arcane magic we have determined that the following fragments from the build log may contain information about the problem. Click to expand the log.I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact |
|
@bors retry -- apparently we can't clone the repo anymore on macOS |
|
@bors treeclosed=100 |
|
@bors retry p=1 |
|
⌛ Testing commit adb54c2 with merge 5eb74cf050c07af96156394ca278aa7f70950a22... |
|
@bors p=19 treeclosed=9 Let's get this merged as soon as possible to avoid invalidating more docker image cache. |
|
💔 Test failed - checks-travis |
|
The job Click to expand the log.I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact |
|
@bors retry |
bors
added a commit
that referenced
this pull request
Feb 17, 2019
[CI] Update GCC in the dist-linux builders Upstream LLVM is planning to raise their minimum toolchain requirements, so they may start using C++14 features. This new policy has already landed in the form of a "soft" error. http://lists.llvm.org/pipermail/llvm-dev/2019-February/130117.html For GCC, they will require at least version 5.1. This PR moves our crosstool-ng builders to their max GCC 5.2, with a few small patches to fix compatibility. The dist-x86_64-linux builder is updated to GCC 5.5 and LLVM/Clang 8.0.0-rc2, which also affects dist-i686-linux sharing the same scripts. r? @alexcrichton
|
Any idea what's invalidating it? It looks like dist-i686-linux has gotten through the docker image a few times, but keeps rebuilding it. The others appear to be cached fine. |
|
☀️ Test successful - checks-travis, status-appveyor |
This comment has been minimized.
This comment has been minimized.
|
@bors treeclosed- 🎉 |
bors
added a commit
that referenced
this pull request
Feb 18, 2019
…crum ci: fix docker cache hash collision #58416 uncovered a bug in our caching for docker images: if the image `foo` pulls files from the image `bar` and a file in `bar` changed, the hash of `foo` will be the same even though it should be different. In that PR's case, `dist-i686-linux` pulls scripts from `dist-x86_64-linux`, and the PR only changed those scripts, causing an hash collision for `dist-i686-linux`. We have to fix this, since the image will be rebuilt every time bors switches from testing master to testing beta/stable (and when it switches back), making CI way more painful than it currently is. The approach used by this PR is to just include all the files in `src/ci/docker` in the hash. It's a bit heavy-handed and it will cause a rebuild of all the images every time a single image changes, but it's the best I can think of. r? @Mark-Simulacrum cc @alexcrichton @kennytm
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Upstream LLVM is planning to raise their minimum toolchain requirements, so they may start using C++14 features. This new policy has already landed in the form of a "soft" error.
http://lists.llvm.org/pipermail/llvm-dev/2019-February/130117.html
For GCC, they will require at least version 5.1. This PR moves our crosstool-ng builders to their max GCC 5.2, with a few small patches to fix compatibility. The dist-x86_64-linux builder is updated to GCC 5.5 and LLVM/Clang 8.0.0-rc2, which also affects dist-i686-linux sharing the same scripts.
r? @alexcrichton