xLTO: Don't pass --plugin-opt=thin to LLD. That's not supported anymore. #55947
Conversation
|
r? @aturon (rust_highfive has picked a reviewer for you, use r? to override) |
|
@bors r+ p=5 Does this need a beta backport as well? |
|
📌 Commit 4cfc979 has been approved by |
|
re: beta, I'll have to look into that. If beta uses an LLVM version the LLD of which also doesn't accept the flag, then yes. |
|
So it looks like the LLD version coming with beta doesn't accept the option either. Beta-nominating. |
…lacrum xLTO: Don't pass --plugin-opt=thin to LLD. That's not supported anymore. It seems that `-plugin-opt=thin` is not needed anymore when invoking LLD for ThinLTO. Unfortunately, still passing the option makes LLD crash instead of giving a deprecation warning or something.
|
☀️ Test successful - status-appveyor, status-travis |
Tested on commit rust-lang/rust@6f93e93. Direct link to PR: <rust-lang/rust#55947> 🎉 rls on linux: test-fail → test-pass (cc @nrc @Xanewok, @rust-lang/infra).
|
Accepted for beta. The patch is low risk and since the feature(s) in question are unstable and have little usage out there make such backport even less dangerous (although that goes the other way as well against the backport). The T-compiler has voted overwhelmingly for a backport. |
[beta] Rollup backports Merged and approved: * #55947: xLTO: Don't pass --plugin-opt=thin to LLD. That's not supported anymore. * #55852: Rewrite `...` as `..=` as a `MachineApplicable` 2018 idiom lint * #55800: Fix ICE in `return_type_impl_trait` * #55630: resolve: Filter away macro prelude in modules with `#[no_implicit_prelude]` on 2018 edition r? @ghost
It seems that
-plugin-opt=thinis not needed anymore when invoking LLD for ThinLTO. Unfortunately, still passing the option makes LLD crash instead of giving a deprecation warning or something.