Add escape-to-raw MIR statement #55716
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
(rust_highfive has picked a reviewer for you, use r? to override) |
|
r? @oli-obk I can also add that to the previous PR, but I felt I shouldn't grow that any further. |
oli-obk
reviewed
Nov 6, 2018
21b8e3b to
5d7d1b4
Compare
|
I declared array index accesses stable places, and added a test. |
|
Ah, I need to change a bit how I emit |
aa0013a to
2d8df3d
Compare
oli-obk
requested changes
Nov 7, 2018
oli-obk
approved these changes
Nov 7, 2018
02b785f to
b891a81
Compare
|
📌 Commit b891a81 has been approved by |
|
💡 This pull request was already approved, no need to approve it again.
|
|
📌 Commit b891a81 has been approved by |
This was referenced Nov 13, 2018
|
@bors p=1 This effectively blocks progress on stacked borrows / miri. |
bors
added a commit
that referenced
this pull request
Nov 15, 2018
Add escape-to-raw MIR statement Add a new MIR "ghost state statement": Escaping a ptr to permit raw accesses. ~~This includes #55549, [click here](RalfJung/rust@miri-visitor...RalfJung:escape-to-raw) for just the new commits.~~
|
☀️ Test successful - status-appveyor, status-travis |
pietroalbini
added a commit
to pietroalbini/rust
that referenced
this pull request
Nov 16, 2018
Make miri value visitor usfeful for mutation This is based on top of rust-lang#55716, [click here](RalfJung/rust@escape-to-raw...RalfJung:mut-visitor) for just the new commits. r? @oli-obk
kennytm
added a commit
to kennytm/rust
that referenced
this pull request
Nov 17, 2018
Make miri value visitor usfeful for mutation ~~This is based on top of rust-lang#55716, [click here](RalfJung/rust@escape-to-raw...RalfJung:mut-visitor) for just the new commits.~~ r? @oli-obk
pietroalbini
added a commit
to pietroalbini/rust
that referenced
this pull request
Nov 18, 2018
Make miri value visitor usfeful for mutation ~~This is based on top of rust-lang#55716, [click here](RalfJung/rust@escape-to-raw...RalfJung:mut-visitor) for just the new commits.~~ r? @oli-obk
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a new MIR "ghost state statement": Escaping a ptr to permit raw accesses.
This includes #55549, click here for just the new commits.