Re-enable drop-locations debuginfo tests. #53152
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@bors r+ rollup |
|
📌 Commit 6608552 has been approved by |
cramertj
added a commit
to cramertj/rust
that referenced
this pull request
Aug 8, 2018
…tion-debuginfo-test, r=kennytm Re-enable drop-locations debuginfo tests. The `-O -C no-prepopulate-passes` workaround doesn't seem to be needed anymore, so it works again for my version of GDB. Let's see what CI says.
cramertj
added a commit
to cramertj/rust
that referenced
this pull request
Aug 8, 2018
…tion-debuginfo-test, r=kennytm Re-enable drop-locations debuginfo tests. The `-O -C no-prepopulate-passes` workaround doesn't seem to be needed anymore, so it works again for my version of GDB. Let's see what CI says.
This was referenced Aug 8, 2018
cramertj
added a commit
to cramertj/rust
that referenced
this pull request
Aug 8, 2018
…tion-debuginfo-test, r=kennytm Re-enable drop-locations debuginfo tests. The `-O -C no-prepopulate-passes` workaround doesn't seem to be needed anymore, so it works again for my version of GDB. Let's see what CI says.
cramertj
added a commit
to cramertj/rust
that referenced
this pull request
Aug 8, 2018
…tion-debuginfo-test, r=kennytm Re-enable drop-locations debuginfo tests. The `-O -C no-prepopulate-passes` workaround doesn't seem to be needed anymore, so it works again for my version of GDB. Let's see what CI says.
|
@bors rollup- This one may have test failure, do not rollup. |
|
⌛ Testing commit 6608552 with merge 6f4055b000bfff1170432720be8a7ac88fdb3273... |
|
💔 Test failed - status-travis |
|
The job Click to expand the log.I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact |
|
⌛ Testing commit 6608552 with merge 1adab913e4162c462993f03f97e7efbb51984129... |
|
💔 Test failed - status-travis |
|
The job Click to expand the log.I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact |
|
Legit. |
|
The test still seems to be flaky. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
-O -C no-prepopulate-passesworkaround doesn't seem to be needed anymore, so it works again for my version of GDB. Let's see what CI says.