Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[beta] Process backports #50478

Merged
merged 2 commits into from
May 6, 2018
Merged

[beta] Process backports #50478

merged 2 commits into from
May 6, 2018

Conversation

pietroalbini
Copy link
Member

@pietroalbini pietroalbini commented May 6, 2018 •
edited
Loading

r? @Mark-Simulacrum

@rust-highfive
Copy link
Collaborator

warning Warning warning

  • Pull requests are usually filed against the master branch for this repo, but this one is against beta. Please double check that you specified the right target!

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label May 6, 2018
@pietroalbini pietroalbini changed the title [beta] Backport 50419 [beta] Process backports May 6, 2018
@pietroalbini pietroalbini mentioned this pull request May 6, 2018
Merged
@rust-highfive

This comment has been minimized.

Sign in to view
@rust-highfive

This comment has been minimized.

Sign in to view
@kennytm
Copy link
Member

kennytm commented May 6, 2018

Both PRs have been merged

@bors r+ p=75

@bors
Copy link
Contributor

bors commented May 6, 2018

📌 Commit efa8a29 has been approved by kennytm

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels May 6, 2018
@bors
Copy link
Contributor

bors commented May 6, 2018

⌛ Testing commit efa8a29 with merge 1ac15ac...

bors added a commit that referenced this pull request May 6, 2018
@bors
Auto merge of #50478 - pietroalbini:beta-backports, r=kennytm
1ac15ac 
[beta] Process backports

* #50419: rustdoc: Resolve nested `impl Trait`s
* #50474: Fix ICE in assertion macro

r? @Mark-Simulacrum
@bors
Copy link
Contributor

bors commented May 6, 2018

☀️ Test successful - status-appveyor, status-travis
Approved by: kennytm
Pushing 1ac15ac to beta...

@bors bors merged commit efa8a29 into rust-lang:beta May 6, 2018
@pietroalbini pietroalbini deleted the beta-backports branch May 6, 2018 22:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@Mark-Simulacrum Mark-Simulacrum

Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@pietroalbini @rust-highfive @kennytm @bors @Mark-Simulacrum @sinkuu