Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[beta] Tweak some stabilizations in libstd #50089

Merged
merged 1 commit into from
Apr 21, 2018
Merged

[beta] Tweak some stabilizations in libstd #50089

merged 1 commit into from
Apr 21, 2018

Conversation

alexcrichton
Copy link
Member

This is a backport of #50088

@alexcrichton
Copy link
Member Author

r? @sfackler

@rust-highfive
Copy link
Collaborator

Your PR failed on Travis (raw log). Through arcane magic we have determined that the following fragments from the build log may contain information about the problem.

Click to expand the log. 
[00:46:43] 
[00:46:43] 
[00:46:43] failed to run: /checkout/obj/build/bootstrap/debug/bootstrap build
[00:46:43] Build completed unsuccessfully in 0:39:55
[00:46:43] make: *** [all] Error 1
[00:46:43] Makefile:28: recipe for target 'all' failed

The command "stamp sh -x -c "$RUN_SCRIPT"" exited with 2.
travis_time:start:030be704
$ date && (curl -fs --head https://google.com | grep ^Date: | sed 's/Date: //g' || true)

I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact @TimNN. (Feature Requests)

@alexcrichton
[beta] Tweak some stabilizations in libstd
222ca2d 
This commit tweaks a few stable APIs in the `beta` branch before they hit
stable. The `str::is_whitespace` and `str::is_alphanumeric` functions were
deleted (added in rust-lang#49381, issue at rust-lang#49657). The `and_modify` APIs added
in rust-lang#44734 were altered to take a `FnOnce` closure rather than a `FnMut` closure.

Closes rust-lang#49581
Closes rust-lang#49657
@pietroalbini pietroalbini added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Apr 20, 2018
@sfackler
Copy link
Member

r=me once #50088 lands

@alexcrichton
Copy link
Member Author

@bors: r=sfackler

@bors
Copy link
Contributor

bors commented Apr 21, 2018

📌 Commit 222ca2d has been approved by sfackler

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Apr 21, 2018
@bors
Copy link
Contributor

bors commented Apr 21, 2018

⌛ Testing commit 222ca2d with merge 7d025f4...

bors added a commit that referenced this pull request Apr 21, 2018
@bors
Auto merge of #50089 - alexcrichton:beta-next, r=sfackler

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
GPG key ID: 4AEE18F83AFDEB23
Expired
Verified
Learn about vigilant mode
7d025f4 
[beta] Tweak some stabilizations in libstd

This is a backport of #50088
@bors
Copy link
Contributor

bors commented Apr 21, 2018

☀️ Test successful - status-appveyor, status-travis
Approved by: sfackler
Pushing 7d025f4 to beta...

@bors bors merged commit 222ca2d into rust-lang:beta Apr 21, 2018
@alexcrichton alexcrichton deleted the beta-next branch April 21, 2018 23:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@sfackler sfackler

Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@alexcrichton @rust-highfive @sfackler @bors @pietroalbini