Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make tidy treat "test/ui/foo.nll.stderr" just like "foo.stderr". #49844

Closed
wants to merge 2 commits into from
Closed

Make tidy treat "test/ui/foo.nll.stderr" just like "foo.stderr". #49844

wants to merge 2 commits into from

Conversation

pnkfelix
Copy link
Member

No description provided.

@rust-highfive
Copy link
Collaborator

r? @nikomatsakis

(rust_highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Apr 10, 2018
@pnkfelix pnkfelix mentioned this pull request Apr 10, 2018
Closed
1 task
@pnkfelix
Copy link
Member Author

(this is part of #48879)

nikomatsakis
nikomatsakis reviewed Apr 10, 2018
View reviewed changes
src/tools/tidy/src/ui_tests.rs Outdated

// rust-lang/rust#48879: this fn used to be beautful
// because Path API special-cases replacing
// extensions. That works great for ".stderr" but not
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

😆

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

beautful -> beautiful

@nikomatsakis
Copy link
Contributor

@bors r+

@bors
Copy link
Contributor

bors commented Apr 10, 2018

📌 Commit ae05961 has been approved by nikomatsakis

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Apr 10, 2018
@pnkfelix pnkfelix mentioned this pull request Apr 10, 2018
Merged
@pnkfelix
Copy link
Member Author

@bors r=nikomatsakis

@bors
Copy link
Contributor

bors commented Apr 10, 2018

📌 Commit 5863cb3 has been approved by nikomatsakis

@pietroalbini
Copy link
Member

@bors rollup

@kennytm kennytm mentioned this pull request Apr 11, 2018
Merged
@pnkfelix
Copy link
Member Author

closing; we will just fold this into #49861

@pnkfelix pnkfelix closed this Apr 11, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@spastorino spastorino spastorino left review comments

@nikomatsakis nikomatsakis nikomatsakis approved these changes

Assignees

@nikomatsakis nikomatsakis

Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@pnkfelix @rust-highfive @nikomatsakis @bors @pietroalbini @spastorino