librustc: Remove simplify_type and replace with sizing_type_of. rs=b...
#4980
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…s=blocking-servo `simplify_type` was bogus, as there was no way for it to handle enums properly. It was also slow, because it created many Rust types at runtime. In general creating Rust types during trans is a source of slowness, and I'd like to avoid doing it as much as possible. (It is probably not possible to eliminate it entirely, due to `subst`, but we should get rid of as much of it as we can.) So this patch replaces `simplify_type` with `sizing_type_of`, which creates a size-equivalent LLVM type directly without going through a Rust type first. Because this is causing an ICE in Servo, I'm rubber stamping it.
bors
added a commit
that referenced
this pull request
Feb 16, 2013
...locking-servo `simplify_type` was bogus, as there was no way for it to handle enums properly. It was also slow, because it created many Rust types at runtime. In general creating Rust types during trans is a source of slowness, and I'd like to avoid doing it as much as possible. (It is probably not possible to eliminate it entirely, due to `subst`, but we should get rid of as much of it as we can.) So this patch replaces `simplify_type` with `sizing_type_of`, which creates a size-equivalent LLVM type directly without going through a Rust type first. Because this is causing an ICE in Servo, I'm rubber stamping it.
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
May 2, 2020
disable let_underscore_must_use in external macros changelog: disable let_underscore_must_use in external macros Closes rust-lang#4980
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
...locking-servo
simplify_typewas bogus, as there was no way for it to handle enumsproperly. It was also slow, because it created many Rust types at runtime. In
general creating Rust types during trans is a source of slowness, and I'd like
to avoid doing it as much as possible. (It is probably not possible to
eliminate it entirely, due to
subst, but we should get rid of as much of itas we can.) So this patch replaces
simplify_typewithsizing_type_of,which creates a size-equivalent LLVM type directly without going through a
Rust type first.
Because this is causing an ICE in Servo, I'm rubber stamping it.