Rollup of 10 pull requests #45818
Closed
Rollup of 10 pull requests #45818
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
kennytm
commented
Nov 7, 2017
•
- Successful merges: add missing docs for MetadataExt #45470, rustbuild: don't try to install rls if ToolState is not Testing #45588, rustdoc: Fix duplicated impls with generics #45620, RwLock guards are Sync if T is #45682, Update the std::thread docs and clarify that panics can nowadays be caught #45714, [xsave] whitelist xsave target feature #45761, rustdoc: add #[allow(unused)] to every doctest #45764, Update reference link in doc's 404 #45778, Display all emission types in error msg if user inputs invalid option. #45782, [intrinsics] add missing div and rem vector intrinsics #45804
- Failed merges:
The same type can appear multiple times in impls so we need to use a set to avoid adding it multiple times.
Currently, the compiler requires `T` to also be `Send`. There is no reason for
that. `&Rw{Read,Write}LockGuard` only provides a shared referenced to `T`, sending
that across threads is safe if `T` is `Sync`.
The Dist Step is not ran in that case so we would end up trying to install something that we didn't dist. Signed-off-by: Marc-Antoine Perennou <Marc-Antoine@Perennou.com>
It's currently linking to a page that says it's on the page I'm changing the link too.
Whitelists `xsave`, `xsaveopt`, `xsavec`, `xsavec`.
also modify the order crate attributes are applied, to have a better order of how things can override lints, either per-crate or per-test
before: ``` > rustc --emit foo error: unknown emission type: `foo` ``` after: ``` > rustc --emit foo error: unknown emission type: `foo` - expected one of: `llvm-bc`, `asm`, `llvm-ir`, `mir`, `obj`, `metadata`, `link`, `dep-info` ```
|
r? @dtolnay (rust_highfive has picked a reviewer for you, use r? to override) |
|
@bors r+ p=11 |
|
📌 Commit fccb414 has been approved by |
|
⌛ Testing commit fccb414c1ee6671fddfa5ffbe6726d5cb0a30a42 with merge 5cbb994d0707633efca1b722d726970d96cd5203... |
|
💔 Test failed - status-travis |
…=QuietMisdreavus add missing docs for MetadataExt r? @rust-lang/docs
rustbuild: don't try to install rls if ToolState is not Testing We already do that for the Dist Step so we would end up trying to install something that we didn't dist.
…r=QuietMisdreavus rustdoc: Fix duplicated impls with generics The same type can appear multiple times in impls so we need to use a set to avoid adding it multiple times. Fixes: rust-lang#45584
RwLock guards are Sync if T is
Currently, the compiler requires `T` to also be `Send`. There is no reason for
that. `&Rw{Read,Write}LockGuard` only provides a shared referenced to `T`, sending
that across threads is safe if `T` is `Sync`.
Cc @oconnor663
Update the std::thread docs and clarify that panics can nowadays be caught
[xsave] whitelist xsave target feature Required for rust-lang/stdarch#171
…ts, r=GuillaumeGomez rustdoc: add #[allow(unused)] to every doctest More information in rust-lang#45750 - this is behavior that was documented but not actually implemented. I also reordered how outer attributes are applied to doctests. Previously, attributes from `#![doc(test(attr(...)))]` would be applied *after* attributes from within the test itself, meaning if a doctest tried to override lints that would be set crate-wide, it wouldn't work at all. This gives a better scope of how lints can be applied. Closes rust-lang#45750
Update reference link in doc's 404 It's currently linking to a page that says it's on the page I'm changing the link too.
…s, r=manishearth Display all emission types in error msg if user inputs invalid option. before: ``` > rustc --emit foo error: unknown emission type: `foo` ``` after: ``` > rustc --emit foo error: unknown emission type: `foo` - expected one of: `llvm-bc`, `asm`, `llvm-ir`, `mir`, `obj`, `metadata`, `link`, `dep-info` ```
[intrinsics] add missing div and rem vector intrinsics
|
@bors r+ |
|
📌 Commit bb3b9ac has been approved by |
|
⌛ Testing commit bb3b9ac with merge fd49c55b963c6feac6a3ba24e043759341fe46ff... |
|
💔 Test failed - status-travis |
|
cargotests' |
|
regression_184 at the tested commit (same content as current master): |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.