-
Notifications
You must be signed in to change notification settings - Fork 13k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add comment explaining the ctxt field in Span #45758
Conversation
Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @petrochenkov (or someone else) soon. If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes. Please see the contribution instructions for more information. |
src/libsyntax_pos/span_encoding.rs
Outdated
@@ -60,8 +60,10 @@ const CTXT_INDEX: usize = 2; | |||
|
|||
// Tag = 0, inline format. | |||
// ----------------------------------- | |||
// | base 31:8 | len 7:1 | tag 0:0 | | |||
// | base 31:8 | len 7:1 | ctxt (currently 0 bits) | tag 0:0 | | |||
// ----------------------------------- |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@nzig
Could you add more ---
s to make it a "closed box" again.
r=me with formatting (#45758 (comment)) fixed |
@bors r+ rollup |
📌 Commit 0220600 has been approved by |
Add comment explaining the ctxt field in Span As discussed in #45747. r? @petrochenkov
☀️ Test successful - status-appveyor, status-travis |
As discussed in #45747.
r? @petrochenkov