Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add comment explaining the ctxt field in Span #45758

Merged
merged 2 commits into from
Nov 6, 2017

Conversation

nzig
Copy link
Contributor

@nzig nzig commented Nov 4, 2017

As discussed in #45747.

r? @petrochenkov

@rust-highfive
Copy link
Collaborator

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @petrochenkov (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see the contribution instructions for more information.

@kennytm kennytm added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Nov 4, 2017
@@ -60,8 +60,10 @@ const CTXT_INDEX: usize = 2;

// Tag = 0, inline format.
// -----------------------------------
// | base 31:8 | len 7:1 | tag 0:0 |
// | base 31:8 | len 7:1 | ctxt (currently 0 bits) | tag 0:0 |
// -----------------------------------
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@nzig
Could you add more ---s to make it a "closed box" again.

@petrochenkov
Copy link
Contributor

r=me with formatting (#45758 (comment)) fixed

@kennytm kennytm added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Nov 4, 2017
@petrochenkov
Copy link
Contributor

@bors r+ rollup
Thanks!

@bors
Copy link
Contributor

bors commented Nov 4, 2017

📌 Commit 0220600 has been approved by petrochenkov

@bors
Copy link
Contributor

bors commented Nov 6, 2017

⌛ Testing commit 0220600 with merge 54bbd56...

bors added a commit that referenced this pull request Nov 6, 2017
Add comment explaining the ctxt field in Span

As discussed in #45747.

r? @petrochenkov
@bors
Copy link
Contributor

bors commented Nov 6, 2017

☀️ Test successful - status-appveyor, status-travis
Approved by: petrochenkov
Pushing 54bbd56 to master...

@bors bors merged commit 0220600 into rust-lang:master Nov 6, 2017
@nzig nzig deleted the explain-span-ctxt branch November 6, 2017 21:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants