-
Notifications
You must be signed in to change notification settings - Fork 13.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
MIR-borrowck: Migrate remaining ast diagnostics #45167
Merged
bors
merged 3 commits into
rust-lang:master
from
pnkfelix:migrate-remaining-ast-diagnostics
Oct 14, 2017
Merged
MIR-borrowck: Migrate remaining ast diagnostics #45167
bors
merged 3 commits into
rust-lang:master
from
pnkfelix:migrate-remaining-ast-diagnostics
Oct 14, 2017
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
r? @arielb1 (rust_highfive has picked a reviewer for you, use r? to override) |
@bors r+ |
📌 Commit 5b68e1f has been approved by |
bors
added a commit
that referenced
this pull request
Oct 14, 2017
…arielb1 MIR-borrowck: Migrate remaining ast diagnostics This PR migrates all of the remaining diagnostics in `rustc_borrowck` over to `rustc_mir`, exposing them for use by both AST-borrowck and MIR-borrowck. This should hopefully resolve all remaining cases of diagnostic messages emitted from borrowck under `-Z borrowck-mir` without an origin annotation.
☀️ Test successful - status-appveyor, status-travis |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
A-diagnostics
Area: Messages for errors, warnings, and lints
S-waiting-on-bors
Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
T-compiler
Relevant to the compiler team, which will review and decide on the PR/issue.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR migrates all of the remaining diagnostics in
rustc_borrowck
over torustc_mir
, exposing them for use by both AST-borrowck and MIR-borrowck.This should hopefully resolve all remaining cases of diagnostic messages emitted from borrowck under
-Z borrowck-mir
without an origin annotation.