-
Notifications
You must be signed in to change notification settings - Fork 13k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add links and examples for std::process::Stdio #45106
Conversation
Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @dtolnay (or someone else) soon. If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes. Please see the contribution instructions for more information. |
src/libstd/process.rs
Outdated
/// Describes what to do with a standard I/O stream for a child process when | ||
/// passed to the [`stdin`], [`stdout`], and [`stderr`] methods of [`Command`]. | ||
/// | ||
/// [`stdin`]: ./struct.Command.html#method.stdin |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't know much about rustdoc but these are the only instances of grep -r '\./struct'
in the whole repo. Could you check whether other docs use a different style for links?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sure, I'll take a look and I'll fix the trailing whitespace.
|
Also remove trailing whitespace to pass tidy checks.
Judging by other examples in the docs, the |
Thanks! Great work on these examples. @bors r+ |
📌 Commit 9772003 has been approved by |
Add links and examples for std::process::Stdio As per rust-lang#29370
As per #29370