Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve debuggability of a few sanitizer tests #44398

Closed
wants to merge 3 commits into from
Closed

Improve debuggability of a few sanitizer tests #44398

wants to merge 3 commits into from

Conversation

alexcrichton
Copy link
Member

Investigating failures on Travis...

@rust-highfive
Copy link
Collaborator

r? @nikomatsakis

(rust_highfive has picked a reviewer for you, use r? to override)

@alexcrichton
Copy link
Member Author

cc @kennytm

Last successful auto build: https://travis-ci.org/rust-lang/rust/jobs/272889516
First failed auto build: https://travis-ci.org/rust-lang/rust/jobs/273020652

Note that the kernel changed between those two builds. My guess is Travis deployed an update and it broke us. No response on their slack channel yet, hoping this can help investigate.

@alexcrichton alexcrichton mentioned this pull request Sep 7, 2017
Merged
@petrochenkov petrochenkov mentioned this pull request Sep 7, 2017
Merged
@alexcrichton alexcrichton added the S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. label Sep 7, 2017
@kennytm
Copy link
Member

kennytm commented Sep 8, 2017 •
edited
Loading

Should we just wait for the 4.4.0-94 kernel (assuming the update will fix the bug mentioned in google/sanitizers#856 (comment)) + Travis cookbook update, and then revert #44399?

@alexcrichton
Copy link
Member Author

Since this works I think I'll land this, that way we don't have to rely on Travis keeping support for an older kernel. I'll comment this, clean it up, and resubmit.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@alexcrichton alexcrichton

Labels
S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@alexcrichton @rust-highfive @kennytm @nikomatsakis