Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run MIR passes on promoted temporaries again. #43902

Merged
merged 1 commit into from
Aug 17, 2017

Conversation

michaelwoerister
Copy link
Member

This seems to have been broken some time in the past (maybe here: 9c154a6#diff-2f8e8805126c84b2be3f0967ffa0af28L162).

r? @arielb1

@@ -148,6 +148,11 @@ fn run_suite<'a, 'tcx>(tcx: TyCtxt<'a, 'tcx, 'tcx>,

pass.run_pass(tcx, source, mir);

for (index, promoted_mir) in mir.promoted.iter_enumerated_mut() {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we have nested promoted MIRs? Because this doesn't handle that.

@michaelwoerister michaelwoerister force-pushed the fix-mir-passes-promoted branch from 451905a to 14d62c6 Compare August 16, 2017 13:46
@arielb1
Copy link
Contributor

arielb1 commented Aug 16, 2017

@bors r+

@bors
Copy link
Contributor

bors commented Aug 16, 2017

📌 Commit 14d62c6 has been approved by arielb1

@aidanhs aidanhs added the S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. label Aug 16, 2017
@bors
Copy link
Contributor

bors commented Aug 17, 2017

⌛ Testing commit 14d62c6 with merge dd39ecf...

bors added a commit that referenced this pull request Aug 17, 2017
…ielb1

Run MIR passes on promoted temporaries again.

This seems to have been broken some time in the past (maybe here: 9c154a6#diff-2f8e8805126c84b2be3f0967ffa0af28L162).

r? @arielb1
@bors
Copy link
Contributor

bors commented Aug 17, 2017

☀️ Test successful - status-appveyor, status-travis
Approved by: arielb1
Pushing dd39ecf to master...

@bors bors merged commit 14d62c6 into rust-lang:master Aug 17, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants