rustdoc: Stop stripping empty modules #42592
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
(rust_highfive has picked a reviewer for you, use r? to override) |
There is no good reason to strip empty modules with no documentation and doing so causes subtle problems.
5ece1a4 to
7298dab
Compare
|
@bors: r+ seems good to me, thanks! |
|
📌 Commit 7298dab has been approved by |
|
⌛ Testing commit 7298dab with merge 58beb20... |
frewsxcv
added a commit
to frewsxcv/rust
that referenced
this pull request
Jun 12, 2017
…eveklabnik rustdoc: Stop stripping empty modules There is no good reason to strip empty modules with no documentation and doing so causes subtle problems. Fixes rust-lang#42590
|
@bors retry prioritizing rollup |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is no good reason to strip empty modules with no documentation and
doing so causes subtle problems.
Fixes #42590