-
Notifications
You must be signed in to change notification settings - Fork 13k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
rustdoc: Hide self: Box<Self>
in list of deref methods
#42394
Conversation
These methods can never be called through deref so there is no point including them. For example you can't call `into_boxed_bytes` or `into_string` on `String`.
(rust_highfive has picked a reviewer for you, use r? to override) |
Nice catch! @bors r+ (I don't think I actually have r+ access yet, but I'm stating it here anyway for the record |
@bors r=QuietMisdreavus (rust-lang/rust-central-station#12) |
📌 Commit 88c791b has been approved by |
⌛ Testing commit 88c791b with merge c5dcc65... |
💔 Test failed - status-travis |
LLDB segfaulted? https://travis-ci.org/rust-lang/rust/jobs/239280446#L8493 @bors retry
|
Uhhhhhh it looks like LLVM segfaulted again, so I'm reluctant to just retry it again, but I have no idea if it's possible that this is related or not... @alexcrichton do you know? |
@bors: retry I think the earlier retry may have been dropped? |
rustdoc: Hide `self: Box<Self>` in list of deref methods These methods can never be called through deref so there is no point including them. For example you can't call [`into_boxed_bytes`](https://doc.rust-lang.org/nightly/std/string/struct.String.html#method.into_boxed_bytes) or [`into_string`](https://doc.rust-lang.org/nightly/std/string/struct.String.html#method.into_string) on `String`.
☀️ Test successful - status-appveyor, status-travis |
These methods can never be called through deref so there is no point including them. For example you can't call
into_boxed_bytes
orinto_string
onString
.