Remove strictly-unnecessary flags for docker #39036
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Oh I tend to like to leave |
|
If by 'debugging' you mean 'dropping into a shell in the container' you'll need to re-add |
|
Ah ok, makes sense. When debugging anyway I have to change something to @bors: r+ p=1 |
|
📌 Commit 8539ce8 has been approved by |
|
⌛ Testing commit 8539ce8 with merge c54a9c7... |
|
@bors: retry |
bors
added a commit
that referenced
this pull request
Jan 13, 2017
Remove strictly-unnecessary flags for docker cc #39035 In addition to `--tty` I've removed `--interactive` as I don't think there's any reason for it to be there (it only hooks up stdin, which shouldn't be used anyway). If this looks like it's working over a few days then I'll also alter the libc scripts. r? @alexcrichton
|
☀️ Test successful - status-appveyor, status-travis |
aidanhs
added a commit
to aidanhs/cargo
that referenced
this pull request
Apr 23, 2017
bors
added a commit
to rust-lang/cargo
that referenced
this pull request
Apr 23, 2017
Remove docker flags that can cause issues See rust-lang/rust#39036
aidanhs
added a commit
to aidanhs/libc
that referenced
this pull request
Apr 23, 2017
bors
added a commit
to rust-lang/libc
that referenced
this pull request
Apr 23, 2017
Remove docker flags that can cause issues See rust-lang/rust#39036 r? @alexcrichton
kennytm
added a commit
to kennytm/rust
that referenced
this pull request
May 21, 2017
* Bring back colors on Travis, which was disabled since rust-lang#39036. Append --color=always to cargo when running in CI environment. * Removed `set -x` in the shell scripts. The `retry` function already prints which command it is running, add `-x` just add noise to the output. * Support travis_fold/travis_time. Matching pairs of these allow Travis CI to collapse the output in between. This greatly cut down the unnecessary "successful" output one need to scroll through before finding the failed statement.
kennytm
added a commit
to kennytm/rust
that referenced
this pull request
Jun 1, 2017
* Bring back colors on Travis, which was disabled since rust-lang#39036. Append --color=always to cargo when running in CI environment. * Removed `set -x` in the shell scripts. The `retry` function already prints which command it is running, add `-x` just add noise to the output. * Support travis_fold/travis_time. Matching pairs of these allow Travis CI to collapse the output in between. This greatly cut down the unnecessary "successful" output one need to scroll through before finding the failed statement.
bors
added a commit
that referenced
this pull request
Jun 2, 2017
Improve Travis CI log (travis_fold, colors) Result looks like (https://travis-ci.org/rust-lang/rust/jobs/234614611): <details><summary>Full page screenshot</summary>  </details> --- * Bring back colors on Travis, which was disabled since #39036. Append `--color=always` to cargo when running in CI environment. * Removed `set -x` from the shell scripts. The `retry` function already prints which command it is running, adding `-x` just adds noise to the output. Interesting information can be manually `echo`ed. * Support `travis_fold`/`travis_time`. Matching pairs of these allow Travis CI to collapse the output in between. This greatly cut down the unnecessary "successful" output one need to scroll through before finding the failed statement. * Passed `--quiet` to all tests, so tests not failing will not occupy a line of log, reducing bloat in the report. Also include some minor changes, like changing the `script` of `.travis.yml` to execute a single-line command, so the log won't write the extremely long multi-line `The command "if [ "$ALLOW_PR" = "" ] && [ "$TRAVIS_BRANCH" != "auto" ]; then … " exited with 0` at the end.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cc #39035
In addition to
--ttyI've removed--interactiveas I don't think there's any reason for it to be there (it only hooks up stdin, which shouldn't be used anyway).If this looks like it's working over a few days then I'll also alter the libc scripts.
r? @alexcrichton