Fix fastcall not applying inreg attributes to arguments #38542
Conversation
|
Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @pnkfelix (or someone else) soon. If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes. Please see the contribution instructions for more information. |
| // See X86_32ABIInfo::shouldPrimitiveUseInReg(), X86_32ABIInfo::updateFreeRegs() | ||
|
|
||
| // IsSoftFloatABI is only set to true on ARM platforms, | ||
| // which in turn can't be x86? |
There was a problem hiding this comment.
Seems like a reasonable deduction.
|
@bors r+ |
|
📌 Commit 5e2cea9 has been approved by |
Fix fastcall not applying inreg attributes to arguments Fixes #18086
|
☀️ Test successful - status-appveyor, status-travis |
| for arg in &mut fty.args { | ||
| if arg.is_ignore() || arg.is_indirect() { continue; } | ||
|
|
||
| if arg.ty.kind() == Float { |
There was a problem hiding this comment.
Is this meant to apply to both f32 and f64 by any chance? LLVM's float is our f32.
There was a problem hiding this comment.
There was a problem hiding this comment.
I think so, the easiest way is writing a test function which has a double as a first argument and then two more ints and comparing current Rust and clang LLVM output.
There was a problem hiding this comment.
Well, I can tell you for a fact that Float there is f32 - there's a Double variant for f64.
Fixes #18086