Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Require #[proc_macro_derive] functions to be pub #38140

Merged
merged 1 commit into from
Dec 19, 2016
Merged

Require #[proc_macro_derive] functions to be pub #38140

merged 1 commit into from
Dec 19, 2016

Conversation

jseyfried
Copy link
Contributor

r? @nrc

@nrc
Copy link
Member

nrc commented Dec 3, 2016

cc @alexcrichton and #35900

@nrc
Copy link
Member

nrc commented Dec 3, 2016

r = me, but I just want a chance for people to see this before I land it.

@nrc nrc mentioned this pull request Dec 3, 2016
Closed
53 tasks
@jseyfried jseyfried force-pushed the proc_macro_visibility branch from 8290c84 to 9c968c5 Compare December 3, 2016 04:03
@alexcrichton
Copy link
Member

Oh I thought this was already the case, I even vaguely remember adding a test for this...

In any case looks good to me as well!

@bors
Copy link
Contributor

bors commented Dec 8, 2016

☔ The latest upstream changes (presumably #38191) made this pull request unmergeable. Please resolve the merge conflicts.

@jseyfried jseyfried force-pushed the proc_macro_visibility branch from 9c968c5 to 6e93d5d Compare December 8, 2016 04:48
@jseyfried jseyfried force-pushed the proc_macro_visibility branch from 6e93d5d to 1605254 Compare December 15, 2016 03:03
@nrc
Copy link
Member

nrc commented Dec 18, 2016

@bors: r+

@bors
Copy link
Contributor

bors commented Dec 18, 2016

📌 Commit 1605254 has been approved by nrc

@nrc nrc added beta-nominated Nominated for backporting to the compiler in the beta channel. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Dec 18, 2016
@bors
Copy link
Contributor

bors commented Dec 19, 2016

⌛ Testing commit 1605254 with merge 0102127...

bors added a commit that referenced this pull request Dec 19, 2016
@bors
Auto merge of #38140 - jseyfried:proc_macro_visibility, r=nrc
0102127 
Require `#[proc_macro_derive]` functions to be `pub`

r? @nrc
@bors
Copy link
Contributor

bors commented Dec 19, 2016

☀️ Test successful - auto-linux-32-nopt-t, auto-linux-32-opt, auto-linux-64-cargotest, auto-linux-64-cross-freebsd, auto-linux-64-debug-opt, auto-linux-64-nopt-t, auto-linux-64-opt, auto-linux-64-opt-rustbuild, auto-linux-64-x-android-t, auto-linux-cross-opt, auto-linux-musl-64-opt, auto-mac-32-opt, auto-mac-64-opt, auto-mac-64-opt-rustbuild, auto-mac-cross-ios-opt, auto-win-gnu-32-opt, auto-win-gnu-32-opt-rustbuild, auto-win-gnu-64-opt, auto-win-msvc-32-opt, auto-win-msvc-64-cargotest, auto-win-msvc-64-opt, auto-win-msvc-64-opt-rustbuild
Approved by: nrc
Pushing 0102127 to master...

@bors bors merged commit 1605254 into rust-lang:master Dec 19, 2016
@jseyfried jseyfried deleted the proc_macro_visibility branch December 19, 2016 04:49
@alexcrichton
Copy link
Member

This just made it into beta, so de-nominating.

@alexcrichton alexcrichton removed the beta-nominated Nominated for backporting to the compiler in the beta channel. label Dec 19, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@nrc nrc

Labels
T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@jseyfried @nrc @alexcrichton @bors