-
Notifications
You must be signed in to change notification settings - Fork 13k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
run rustfmt on librustc_incremental folder #37346
Conversation
r? @arielb1 (rust_highfive has picked a reviewer for you, use r? to override) |
@arielb1 LGTM. What do you think? |
} else { | ||
'_' | ||
}) | ||
.collect(); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, this is probably the trickiest corner of formatting at the moment - I prefer visual indent for method chains, but it makes closures either ugly or subject to extreme rightward drift.
r? @nrc |
☔ The latest upstream changes (presumably #37439) made this pull request unmergeable. Please resolve the merge conflicts. |
☔ The latest upstream changes (presumably #37540) made this pull request unmergeable. Please resolve the merge conflicts. |
r = me with a rebase |
Closing due to inactivity. @srinivasreddy If you're still interested in these changes, let me know and I can reopen, otherwise you could just open a new PR. |
No description provided.