Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix RUSTC_VERSION for 'documenting' build stage. #36877

Merged
merged 1 commit into from
Oct 1, 2016
Merged

Fix RUSTC_VERSION for 'documenting' build stage. #36877

merged 1 commit into from
Oct 1, 2016

Conversation

solson
Copy link
Member

@solson solson commented Sep 30, 2016

Previously the env!("RUSTC_VERSION") requirement would break the "Documenting rustc_metadata" stage of the rustc build, since that environment variable is only defined during the main build.

r? @eddyb

Previously the `env!("RUSTC_VERSION")` requirement would break the
"Documenting rustc_metadata" stage of the rustc build, since that
environment variable is only defined during the main build.
@eddyb
Copy link
Member

eddyb commented Sep 30, 2016

@bors r+

@bors
Copy link
Contributor

bors commented Sep 30, 2016

📌 Commit 41832f2 has been approved by eddyb

Manishearth added a commit to Manishearth/rust that referenced this pull request Oct 1, 2016
…=eddyb

Fix RUSTC_VERSION for 'documenting' build stage.

Previously the `env!("RUSTC_VERSION")` requirement would break the "Documenting rustc_metadata" stage of the rustc build, since that environment variable is only defined during the main build.

r? @eddyb
bors added a commit that referenced this pull request Oct 1, 2016
Rollup of 6 pull requests

- Successful merges: #36865, #36872, #36873, #36877, #36880, #36882
- Failed merges:
@bors bors merged commit 41832f2 into rust-lang:master Oct 1, 2016
@solson solson deleted the rustc-version-build-issue branch October 2, 2016 19:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants