Reimplement TokenStreams using ropes #35018
Conversation
|
Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @nrc (or someone else) soon. If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes. Please see the contribution instructions for more information. |
| } | ||
|
|
||
|
|
||
| impl clone::Clone for TokenStream { |
There was a problem hiding this comment.
Why doesn't deriving work? In any case, clone:: is not necessary, Clone is in scope.
There was a problem hiding this comment.
I just wanted to make sure it did the right thing; it's possible deriving works fine.
| Span { | ||
| lo: if sp1.lo < sp2.lo { sp1.lo } else { sp2.lo }, | ||
| hi: if sp1.hi > sp2.hi { sp1.hi } else { sp2.hi | ||
| }, |
a215ffc to
43f852c
Compare
|
The last bors build is... strange. It's suggesting errors in code that simply doesn't exist. (cc @alexcrichton) |
|
@cgswords maybe it's some random unit test somewhere? Travis may also get confused if lots of tests are scheduled at once (not sure) |
|
@cgswords That code exists upstream -- I think Travis is merging with |
|
@jseyfried That's certainly what's happened; I just wasn't expecting it. Thanks! |
|
@cgswords no problem! |
|
@cgswords could you squash the commits please? r=me with that |
|
@bors: r+ |
|
📌 Commit dc259de has been approved by |
Reimplement TokenStreams using ropes Title says it all; a reimplementation of TokenStreams as ropes. r? @nrc
Title says it all; a reimplementation of TokenStreams as ropes.
r? @nrc