Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

don't const eval constants during MIR creation #34657

Merged
merged 1 commit into from
Jul 10, 2016
Merged

don't const eval constants during MIR creation #34657

merged 1 commit into from
Jul 10, 2016

Conversation

oli-obk
Copy link
Contributor

@oli-obk oli-obk commented Jul 5, 2016

this didn't work very well anyway, because const_eval can't eval all kinds of constants.

@oli-obk
don't const eval constants during MIR creation
e7b083a 
this didn't work very well anyway, because const_eval can't eval all kinds of constants.
@rust-highfive
Copy link
Collaborator

r? @pnkfelix

(rust_highfive has picked a reviewer for you, use r? to override)

@oli-obk
Copy link
Contributor Author

oli-obk commented Jul 10, 2016

r? @eddyb

@rust-highfive rust-highfive assigned eddyb and unassigned pnkfelix Jul 10, 2016
@eddyb
Copy link
Member

eddyb commented Jul 10, 2016

@bors r+

@bors
Copy link
Contributor

bors commented Jul 10, 2016

📌 Commit e7b083a has been approved by eddyb

@bors
Copy link
Contributor

bors commented Jul 10, 2016

⌛ Testing commit e7b083a with merge 6871b3f...

bors added a commit that referenced this pull request Jul 10, 2016
@bors
Auto merge of #34657 - oli-obk:no_needless_const_eval, r=eddyb
6871b3f 
don't const eval constants during MIR creation

this didn't work very well anyway, because const_eval can't eval all kinds of constants.
@bors
Copy link
Contributor

bors commented Jul 10, 2016

☀️ Test successful - auto-linux-32-nopt-t, auto-linux-32-opt, auto-linux-64-cargotest, auto-linux-64-cross-freebsd, auto-linux-64-debug-opt, auto-linux-64-nopt-t, auto-linux-64-opt, auto-linux-64-opt-mir, auto-linux-64-opt-rustbuild, auto-linux-64-x-android-t, auto-linux-cross-opt, auto-linux-musl-64-opt, auto-mac-32-opt, auto-mac-64-opt, auto-mac-64-opt-rustbuild, auto-mac-cross-ios-opt, auto-win-gnu-32-opt, auto-win-gnu-32-opt-rustbuild, auto-win-gnu-64-opt, auto-win-msvc-32-opt, auto-win-msvc-64-cargotest, auto-win-msvc-64-opt, auto-win-msvc-64-opt-mir, auto-win-msvc-64-opt-rustbuild
Approved by: eddyb
Pushing 6871b3f to master...

@bors bors merged commit e7b083a into rust-lang:master Jul 10, 2016
@oli-obk oli-obk deleted the no_needless_const_eval branch June 15, 2020 15:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@eddyb eddyb

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@oli-obk @rust-highfive @eddyb @bors @pnkfelix