implement fuzzy matching in on_unimplemented #33694
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -523,8 +523,7 @@ impl<T> SliceExt for [T] { | |||
| } | |||
|
|
|||
| #[stable(feature = "rust1", since = "1.0.0")] | |||
| #[allow(unused_attributes)] | |||
| #[rustc_on_unimplemented = "a usize is required to index into a slice"] | |||
| #[rustc_on_unimplemented = "slice indexes must be usizes"] | |||
There was a problem hiding this comment.
Just to make sure the message is as clear as possible to the users that will be helped, maybe we can change to “slice index type must be usize”? I just think the “usizes” formulation will be confusing.
| def_a == def_b, | ||
| _ => cat_a == cat_b | ||
| }, | ||
| // infer and error are |
There was a problem hiding this comment.
Nit: incomplete sentence... "infer and error are fuzzy equal to all types", I guess?
There was a problem hiding this comment.
Nit: incomplete sentence... "infer and error are fuzzy equal to all types", I guess?
|
Looks great! r=me after nits and once we settle on a good wording for the error message :) |
363ff9c to
b344c71
Compare
|
|
| @@ -523,8 +523,7 @@ impl<T> SliceExt for [T] { | |||
| } | |||
|
|
|||
| #[stable(feature = "rust1", since = "1.0.0")] | |||
| #[allow(unused_attributes)] | |||
| #[rustc_on_unimplemented = "a usize is required to index into a slice"] | |||
| #[rustc_on_unimplemented = "slice indices are of type usize"] | |||
|
@bors r=nikomatsakis |
|
📌 Commit b344c71 has been approved by |
|
r=me modulo nit |
|
@bors r=nikomatsakis |
|
📌 Commit b9a201c has been approved by |
bors
added a commit
that referenced
this pull request
May 19, 2016
implement fuzzy matching in on_unimplemented Fixes #31062 r? @nikomatsakis
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #31062
r? @nikomatsakis