-
Notifications
You must be signed in to change notification settings - Fork 13k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rollup of 14 pull requests #32351
Merged
Merged
Rollup of 14 pull requests #32351
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Both Packages and Ports of FreeBSD have Cargo in present.
The opt-in functionality was proposed and discussed in rust-lang#21195
I think it's a mistake of spelling.
I changes *expression* to *statement* to make more accurate, because in Rust, `let` introduces a declaration statement.
f32 should probably be denoted as 0.0 as it might improve readability. Signed-off-by: benaryorg <binary@benary.org>
Apparently the NetBSD compiler-rt builds into the linux directory as well. I'm... detecting a trend!
It's basically the very definition of a newtype, so we might as well make things easy on people and let them construct and access it directly.
…the return type Fixes rust-lang#32323
`-march` should definitely go last, after the environment C(XX)FLAGS, or it's back to square one. This fixes cross-compilation issues on x86_64.
FreeBSD has already supported Cargo Both Packages and Ports of FreeBSD have Cargo in present.
…ikomatsakis syntax: impl ToTokens for P<ast::ImplItem> I'm working on updating zinc for latest rust, and it appears that I need this impl[0]. More generally, I realise that libsyntax is "Whatever the compiler team needs to build a compiler", but should I just open a PR fleshing this out for all types? https://github.com/hackndev/zinc/blob/master/ioreg/src/builder/setter.rs#L194-L197
…ote, r=nikomatsakis Add comment about opt-in nature of compiletest note/help messages. The opt-in functionality was proposed and discussed in rust-lang#21195
docs: One typo I think it's a mistake of spelling.
Fix usability problem when browse document locally You cannot use `history.replaceState` when you browse locally, it breaks the security policy of Chrome and perhaps other browsers. Closes rust-lang#32307 Thank @crumblingstatue for the help!
docs: `let` introduces a statement I changes *expression* to *statement* to make more accurate, because in Rust, `let` introduces a declaration statement.
documentation fix in RELEASES.md f32 should probably be denoted as 0.0 as it might improve readability.
…aric rustbuild: Fix cross to netbsd from Linux Apparently the NetBSD compiler-rt builds into the linux directory as well. I'm... detecting a trend!
Minor phrasing adjustment to book references-and-borrowing
…=aturon Make AssertRecoverSafe's field public It's basically the very definition of a newtype, so we might as well make things easy on people and let them construct and access it directly. r? @aturon
liveness: substitute bound regions with free ones before normalizing the return type Fixes rust-lang#32323 r? @arielb1
Update LLVM to include a backport to restore AA performance cc rust-lang#31435 r? @alexcrichton
Use explicit -march flags in the i586 mk file `-march` should definitely go last, after the environment `$C(XX)FLAGS`, or it's going to remain brittle. This should fix cross-compilation issues on x86_64 (possibly x86 too on some newer distros) - it was far too assuming of me to expect you really had to want i586 using your own flags.
Fix volatile stores of fat pointers This was previously causing an LLVM assertion. r? @eddyb
(rust_highfive has picked a reviewer for you, use r? to override) |
@bors r+ p=1 |
📌 Commit 5bf1e58 has been approved by |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
let
introduces a statement #32316, documentation fix in RELEASES.md #32319, rustbuild: Fix cross to netbsd from Linux #32321, Minor phrasing adjustment to book references-and-borrowing #32327, Make AssertRecoverSafe's field public #32329, liveness: substitute bound regions with free ones before normalizing the return type #32332, Update LLVM to include a backport to restore AA performance #32337, Use explicit -march flags in the i586 mk file #32342, Fix volatile stores of fat pointers #32347