Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expose the key of Entry variants for HashMap and BTreeMap. #32248

Merged
merged 2 commits into from
Mar 18, 2016

Conversation

dstu
Copy link
Contributor

@dstu dstu commented Mar 14, 2016

This PR addresses issue 1541 by exposing the key of HashMap and BTreeMap entry variants. Basic tests are provided.

@rust-highfive
Copy link
Collaborator

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @aturon (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see the contribution instructions for more information.

@@ -1465,6 +1465,13 @@ impl<'a, K: Ord, V> Entry<'a, K, V> {
}

impl<'a, K: Ord, V> VacantEntry<'a, K, V> {
/// Gets a reference to the key that would be used when inserting a value
/// through the VacantEntry.
#[unstable(feature = "map_entry_keys", issue = "1541")]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this will have to reference an issue in the rust-lang/rust repo, not rust-lang/rfcs.

@sfackler sfackler added I-needs-decision Issue: In need of a decision. T-libs-api Relevant to the library API team, which will review and decide on the PR/issue. labels Mar 16, 2016
@alexcrichton
Copy link
Member

The libs team discussed this yesterday during triage and the decision was to merge. Thanks for the PR @dstu!

cc @gereeter, @pczarn, @gankro

@bors: r+ 2ddba6f

@alexcrichton alexcrichton removed I-needs-decision Issue: In need of a decision. T-libs-api Relevant to the library API team, which will review and decide on the PR/issue. labels Mar 17, 2016
@pczarn
Copy link
Contributor

pczarn commented Mar 17, 2016

This PR pushes the API in the right direction. See also issue 1533: Keyless Entry.

@bors
Copy link
Contributor

bors commented Mar 18, 2016

⌛ Testing commit 2ddba6f with merge 2de6ddd...

bors added a commit that referenced this pull request Mar 18, 2016
Expose the key of Entry variants for HashMap and BTreeMap.

This PR addresses [issue 1541](rust-lang/rfcs#1541) by exposing the key of `HashMap` and `BTreeMap` entry variants. Basic tests are provided.
@bors bors merged commit 2ddba6f into rust-lang:master Mar 18, 2016
@bors bors mentioned this pull request Mar 18, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants