[rustbuild] fix cross compilation of std for mips(el)-linux-musl #32027
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These targets don't link statically to libunwind or libc
| @@ -79,7 +79,7 @@ pub fn check(build: &mut Build) { | |||
| } | |||
|
|
|||
| // Make sure musl-root is valid if specified | |||
| if target.contains("musl") { | |||
| if target.contains("musl") && target.contains("x86_64") { | |||
There was a problem hiding this comment.
What about i686-unknown-linux-musl?
There was a problem hiding this comment.
Hmm, we don't provide binaries releases of std for that target (yet). But I guess we probably want to use static linking for that target as well because is not memory constrained like the mips are. @alexcrichton ?
There was a problem hiding this comment.
Right, we'd want to use static linking if it worked, but I don't think it would even get past compiling libstd today.
There was a problem hiding this comment.
OK, I'll interpret that as: "let's add i686 here after we confirm we can cross compile std to it using rustbuild".
There was a problem hiding this comment.
Ah yes, that was indeed what I intended to convey :)
Manishearth
added a commit
to Manishearth/rust
that referenced
this pull request
Mar 4, 2016
These targets don't link statically to libunwind or libc --- r? @alexcrichton
steveklabnik
added a commit
to steveklabnik/rust
that referenced
this pull request
Mar 4, 2016
These targets don't link statically to libunwind or libc --- r? @alexcrichton
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These targets don't link statically to libunwind or libc
r? @alexcrichton