more check_*_post methods for LintPasses #31926
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
r? @eddyb I'm not going to review PRs that directly benefit clippy 😄 . Though this LGTM |
|
One of these days it will be automated... |
|
📌 Commit d315dc6 has been approved by |
|
⌛ Testing commit d315dc6 with merge a2cf252... |
Manishearth
added a commit
to Manishearth/rust
that referenced
this pull request
Feb 27, 2016
These `_post` methods are quite helpful to control lint behavior without storing e.g. block node ids. So here are a few more I believe will be helpful. r? @Manishearth
|
⛄ The build was interrupted to prioritize another pull request. |
|
@Manishearth I just asked for you because you know the code in question very well. Just for the record, this is no tatkeover attempt of rustc's lint interface by clippy. 😄 |
bors
added a commit
that referenced
this pull request
Feb 27, 2016
These `_post` methods are quite helpful to control lint behavior without storing e.g. block node ids. So here are a few more I believe will be helpful. r? @Manishearth
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These
_postmethods are quite helpful to control lint behavior without storing e.g. block node ids. So here are a few more I believe will be helpful.r? @Manishearth