-
Notifications
You must be signed in to change notification settings - Fork 13.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement Clone
for std::vec::IntoIter
#31704
Conversation
r? @aturon (rust_highfive has picked a reviewer for you, use r? to override) |
@tbu- Thanks for the PR! Would you mind saying a bit about the motivation for this change? cc @rust-lang/libs, we've been somewhat shy about adding APIs to iterators, and I'm not sure we've discussed the case of a trait impl like this. |
I just saw this IRC message today and wondered why |
I believe that Basically, sounds good to me! |
@@ -1633,6 +1634,15 @@ impl<T> DoubleEndedIterator for IntoIter<T> { | |||
#[stable(feature = "rust1", since = "1.0.0")] | |||
impl<T> ExactSizeIterator for IntoIter<T> {} | |||
|
|||
#[stable(feature = "vec_into_iter_clone", since = "1.7.0")] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should this be 1.8.0?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can I get a definitive statement for this? Should it be 1.8.0?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
1.8.0, yes. That's the current nightly, slated to become beta next week.
e236ba1
to
8fd7469
Compare
OK, it's now 1.8.0. |
@bors: r+ Thanks! |
📌 Commit 8fd7469 has been approved by |
No description provided.