-
Notifications
You must be signed in to change notification settings - Fork 13k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement placement-in protocol for LinkedList
#31696
Conversation
I am not a member of the libs team, but my intuition is that the name Unfortunately deciding on a name for such methods does imply a bikeshedding discussion. . . |
Cc @rust-lang/libs |
@pnkfelix Agreed. Unfortunately, |
|
From a library API perspective this seems fine to me for now, we'll likely want to do a sweeping audit whenever we consider this for stabilization (aligning names for example), but for now having this as unstable seems fine to me! |
@alexcrichton So should I update any of the names for now? |
Oh I guess we don't have any prior art here (sorry I thought we had these implemented for vectors). In terms of naming, we'll probably want to have a convention like iterators where it's super straightforward and you don't have to think about it much. Along those lines maybe something like:
So I guess within those guidelines, I'd recommend renaming the returned structs, and otherwise keeping the names as is or the |
Updated. |
@bors r+ |
📌 Commit 895ab4f has been approved by |
CC #30172.
r? @pnkfelix
CC @nagisa